Repository navigation
Fix QA group [sources] path so develop_sources! resolves repo root - #131
Merged
ChrisRackauckas merged 1 commit intoJun 15, 2026
Merged
Conversation
The QA group's test/qa/Project.toml declared the in-repo package source as `path = ".."`, which resolves relative to the env directory test/qa to test/ — a directory with no Project.toml. With SciMLTesting v1.2's run_tests (PR SciML#129), activate_group_env now walks the [sources] graph via develop_sources! (the Julia 1.10 [sources] backport) and Pkg.develop's each path, so it errors: could not find project file (Project.toml or JuliaProject.toml) in package at `.../test/` maybe `subdir` needs to be specified The env directory test/qa is two levels below the repo root, so the source path must be ../.. (matching every other converted SciML repo, e.g. SciMLOperators/SciMLStructures). This made both the QA and Core grouped-test jobs fail on the LTS (Julia 1.10) where the [sources] backport is active. Verified locally on Julia 1.10: GROUP=QA now passes (QA 10/10) and GROUP=Core passes; before the fix GROUP=QA reproduced the CI error exactly. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
marked this pull request as ready for review
June 15, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Master CI is red: both the
QAandCoregrouped-test jobs fail on the LTS (Julia 1.10) with:The error originates in
SciMLTesting.develop_sources!<-activate_group_env<-run_tests(test/runtests.jl:9).Root cause
test/qa/Project.tomldeclared the in-repo package source as:[sources]paths resolve relative to the directory of theProject.tomlthat declares them. The env dir istest/qa, so".."resolves totest/-- which has noProject.toml.This was latent until #129 switched to SciMLTesting v1.2's
run_tests. Itsactivate_group_envnow walks the[sources]graph viadevelop_sources!(the Julia 1.10[sources]backport -- a no-op on 1.11+) andPkg.develops each path, so the bad path now errors. On 1.10 this breaks both the QA group and the Core job.The env dir
test/qais two levels below the repo root, so the path must be../..-- matching every other converted SciML repo (e.g. SciMLOperators.jl, SciMLStructures.jl).Fix
Local verification (Julia 1.10, the LTS)
GROUP=QA julia +1.10 -e 'using Pkg; Pkg.test()'reproduced the CI error exactly.GROUP=QA->QA | 10 10(Aqua passes),tests passed.GROUP=Core->tests passed.Please ignore until reviewed by @ChrisRackauckas.