Repository navigation
Add scale-free reservoir initializer - #578
aviralgarg05 wants to merge 2 commits into
Conversation
Implement an undirected Barabasi-Albert topology with reproducible weighted connections, spectral-radius scaling, and sparse output support. Add validation, API docs, and focused topology tests.
PR: #578 Reviewed head: 8355a14 Risk assessment
Review reportVERDICT: CHANGES Riskmedium-low (ML7: new exported initializer with a docstring, rendered API entry and tests) Blocking findings
Non-blocking findings
What I ran
What I did not verifyGPU behavior, large-reservoir performance and test groups outside Core. I did not inspect remote CI. AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":3,"rounds":1,"author_harness":"unknown","author_model":"unknown","note":"The attachment implementation, call forms, sparse output and docs passed independent checks. The tests accept uniform attachment, and valid Float32 and Float16 calls silently miss the requested spectral radius."} Head link: 8355a14 🤖 Posted by an AI agent — harness: codex-cli 0.170.0 · model: gpt-6.2-astra |
|
Thanks for the detailed reproductions. I reproduced all three blocking cases locally and addressed them. Radius scaling now uses widened precision, verifies the realized output radius, and redraws weights on the same topology when output rounding makes a sample unsuitable. Invalid radii and unsupported element types are rejected before the RNG is consumed. I also added a deterministic preferential-attachment regression and the reported Float32/Float16 cases. The full Core suite passes, including 974 initializer tests, along with 1,500 additional seed/type radius checks. |
PR: #578 Reviewed head: 819f564 Risk assessment
Review reportVERDICT: CHANGES Riskmedium-low (ML7: new exported initializer with a docstring, rendered API entry and tests. Existing initializer calls retain their behavior.) Blocking findings
Non-blocking findings
What I ran
What I did not verifyOther Julia versions, groups outside Core and large-reservoir timing. The CI status above was supplied for this head. AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":3,"rounds":2,"author_harness":"unknown","author_model":"unknown","note":"The new test detects uniform attachment and both unit-radius regressions pass. Representable subunit targets can still miss by over 100%, and narrowing accepts some negative inputs."} Head link: 819f564 🤖 Posted by an AI agent — harness: codex-cli 0.169.0 · model: gpt-6.2-astra |
Summary
Tests
GROUP=Core julia --project -e 'using Pkg; Pkg.test()'julia --project -e 'using Test; include("test/inits_tests.jl")'Fixes #387