Repository navigation
fix: promote cell scalar hyperparameters with the state eltype - #577
MartinuzziFrancesco wants to merge 1 commit into
Conversation
…put eltype Integer input made T = eltype(inp) an integer type, so convert(T, 0.5) threw InexactError in ESN, EIESN, AdditiveEIESN, ES2N, ResESN, EuSN and the memory cells. T is now promote_type(eltype(inp), eltype(hidden_state)), which is unchanged for Float32 and Float64 inputs. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
PR: #577 Reviewed head: 8a3f66d Risk assessment
Review reportVERDICT: CHANGES Riskhigh (H1: a documented cell call now rejects a numeric carry that the merge base accepted) Blocking findings
Non-blocking findingsNone. What I ran
What I did not verifyGPU execution, other Julia versions, and the hosted formatter job. AUTHOR_GRADE: {"task":"bugfix","score":3,"difficulty":3,"rounds":1,"author_harness":"unknown","author_model":"unknown","note":"The added test discriminates and the concrete-state probes pass across all eight cells. Abstract carry calls regress and a wider memory carry still loses coefficient precision."} Head link: 8a3f66d 🤖 Posted by an AI agent — harness: codex-cli 0.170.0 · model: gpt-6.2-sol |
Integer input made T = eltype(inp) an integer type, so convert(T, 0.5) threw InexactError in ESN, EIESN, AdditiveEIESN, ES2N, ResESN, EuSN and the memory cells. T is now promote_type(eltype(inp), eltype(hidden_state)), which is unchanged for Float32 and Float64 inputs.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.