Repository navigation
Add Watts-Strogatz small-world reservoir initializer - #574
Conversation
|
implementation looks ok, the docstrings need to be in line with the ones of the other initializers (examples...) and then wired in here |
PR: #574 Reviewed head: 407c672 Risk assessment
Review reportVERDICT: CHANGES Riskmedium-low (ML7: additive, opt-in exported reservoir initializer; existing calls and defaults are unchanged. The documentation blocker is resolved, but the Float16 topology blocker remains.) Blocking findings
Non-blocking findingsNone. No additional defects found in the documentation delta. What I ranAll commands export
What I did not verify
AUTHOR_GRADE: {"task": "feature", "score": 3, "difficulty": 3, "rounds": 2, "author_harness": "unknown", "author_model": "unknown", "note": "The documentation delta resolves the missing-export build failure: the actual docs build and Core suite pass. An independent analytic-ring probe still reproduces the preceding Float16 topology defect, with 78 connections instead of 80 and asymmetric support."} Head link: 407c672 🤖 Posted by an AI agent — harness: Devin 3000.12.57 · model: fusion-gpt-6-1-sol-high-sidekick-swe-2-medium |
Avoid zero edge weights so finite-precision sampling retains the selected graph support. Cover the regression with a deterministic Float16 ring test.
PR: #574 Reviewed head: 2c634eb Risk assessment
Review reportVERDICT: MERGE Riskmedium-low (ML7: additive, opt-in exported initializer; existing calls and defaults are unchanged. The delta resolves the preceding Float16 topology blocker with a discriminating regression.) Blocking findingsNone. Confirmed by running: the preceding Float16 reproducer now has all 80 required connections and exactly matches the analytic ring support.
Non-blocking findingsNone found in the delta. The zero-weight replacement at What I ranCommands export
What I did not verify
AUTHOR_GRADE: {"task": "feature", "score": 4, "difficulty": 3, "rounds": 3, "author_harness": "unknown", "author_model": "unknown", "note": "The delta resolves the preceding Float16 topology defect: the same independent analytic-ring assertions fail on the preceding initializer and pass on this head. All 1371 Core assertions and 2490 targeted probe assertions pass; existing tested Float32/Float64 results and RNG state remain unchanged."} Head link: 2c634eb 🤖 Posted by an AI agent — harness: Devin 3000.12.57 · model: fusion-gpt-6-1-sol-high-sidekick-swe-2-medium |
Closes #269
This adds
small_world, a Watts-Strogatz reservoir initializer with sampled connection weights, spectral-radius scaling, and the standard initializer call forms.The implementation validates the matrix shape, neighbour count, and rewiring probability. It supports sparse output through the existing extension mechanism.
Tests cover deterministic seeded output, lattice and rewired topology properties, radius scaling, sparse output, fallback API calls, and invalid inputs.
Testing:
Pkg.test()Runic --checkon the changed files