Skip to content

fix: extend LuxCore.parameterlength, docstring corrections, dead code - #568

Merged
MartinuzziFrancesco merged 1 commit into
masterfrom
fm/fix-parameterlength-docs-cleanup
Oct 24, 2026
Merged

MartinuzziFrancesco merged 1 commit into
masterfrom
fm/fix-parameterlength-docs-cleanup

Conversation

@MartinuzziFrancesco

@MartinuzziFrancesco MartinuzziFrancesco commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator
  • parameterlength for LinearReadout and SVMReadout now extends LuxCore.parameterlength instead of defining a separate unexported function.
  • ESNCell, EuSNCell and MemoryESNCell docstrings list init_bias = zeros32, matching the constructors.
  • self_loop! docstring describes what it does (it was copied from add_jumps!).
  • Extension load messages no longer ask to load SciMLBase, a hard dependency.
  • Initializer docstrings state the rng-less default rng, Xoshiro(1234), instead of attributing it to WeightInitializers.
  • RECA docstring documents readout_in_dims.
  • Remove RCFields, __set_readout, commented-out code lines, and __fillvec (replaced by fill).

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

- parameterlength for LinearReadout and SVMReadout now extends
  LuxCore.parameterlength instead of defining a separate unexported function.
- ESNCell, EuSNCell and MemoryESNCell docstrings list init_bias = zeros32,
  matching the constructors.
- self_loop! docstring describes what it does (it was copied from add_jumps!).
- Extension load messages no longer ask to load SciMLBase, a hard dependency.
- Initializer docstrings state the rng-less default rng, Xoshiro(1234),
  instead of attributing it to WeightInitializers.
- RECA docstring documents readout_in_dims.
- Remove RCFields, __set_readout, commented-out code lines, and __fillvec
  (replaced by fill).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MartinuzziFrancesco
MartinuzziFrancesco merged commit 3eb64b2 into master Oct 24, 2026
60 checks passed
@MartinuzziFrancesco
MartinuzziFrancesco deleted the fm/fix-parameterlength-docs-cleanup branch October 24, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant