Repository navigation
fix: NonlinearFeaturesLayer on matrix input, EuSNCell allocations - #567
Merged
Merged
Conversation
…tions NonlinearFeaturesLayer only had an AbstractVector method. Reservoir cells inside a ReservoirChain output n x 1 matrices, so a chain with a NonlinearFeaturesLayer after a cell threw a MethodError in collectstates, train! and predict. Matrix input is now handled column by column, so non-elementwise features such as kron(x, x) work, and the Any[] buffer is gone. The vector method returns the same values as before. EuSNCell built W - W' - gamma*I plus a dense identity on every step. It now computes W*h - W'*h - gamma*h (324 KB -> 5.6 KB per step at n = 200). The bias is added with the input term, after the recurrent difference, so a large symmetric W cannot round it away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NonlinearFeaturesLayer only had an AbstractVector method. Reservoir cells inside a ReservoirChain output n x 1 matrices, so a chain with a NonlinearFeaturesLayer after a cell threw a MethodError in collectstates, train! and predict. Matrix input is now handled column by column, so non-elementwise features such as kron(x, x) work, and the Any[] buffer is gone. The vector method returns the same values as before.
EuSNCell built W - W' - gammaI plus a dense identity on every step. It now computes Wh - W'h - gammah (324 KB -> 5.6 KB per step at n = 200). The bias is added with the input term, after the recurrent difference, so a large symmetric W cannot round it away.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.