Repository navigation
Allow JET 0.12 in the QA environment for Julia 1.13 - #682
Merged
Merged
Conversation
General now restricts JET 0.10.15 and 0.11.4-0.11.6 to Julia 1.12, so the JET-using test environments cannot resolve on Julia 1.13 unless JET 0.12 is allowed. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.11.92 Agent-Model: fusion-claude-opus-5-5-high-sidekick-swe-2-medium Agent-Session: local headless Devin run (fleet master JET lane; no session URL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a failure on the default branch's CI. The diagnosis and the evidence below come from the investigating agent's report; "confirmed by running" and "read in logs" are kept apart there.
Change
JET = "0.9, 0.10, 0.11"->"0.9, 0.10, 0.11, 0.12"in:No .jl files changed, so Runic was not needed.
typoson the changed files: clean.Environment
export TMPDIR=<sandbox>/tmp CUDA_VISIBLE_DEVICES="" JULIA_NUM_THREADS=4JET is not in the root QA env (test/QA). It is used by the
NoPregroup and by each sublibrary's QA env, which runs fromlib/<Sublib>withRECURSIVEARRAYTOOLS_TEST_GROUP=QA.Commands and results
Commands:
GROUP=QA julia +<ch> --project -e 'using Pkg; Pkg.test()'(repo root)GROUP=NoPre julia +<ch> --project -e 'using Pkg; Pkg.test()'(repo root)RECURSIVEARRAYTOOLS_TEST_GROUP=QA julia +<ch> --project -e 'using Pkg; Pkg.test()'(in lib/)Before (master, Julia 1.13.2): NoPre and all 3 sublib QA envs fail to resolve:
Unsatisfiable requirements detected for package JET ... restricted by julia compatibility requirements to versions: 0.12.0 - 0.12.3 or uninstalled — no versions leftAfter (branch):
+release)+lts)JET reports
JET 0.12.3 reports nothing new, so no code fixes were needed. The one "broken" result in RaggedArrays on 1.13 comes from the
jet_broken = VERSION >= v"1.11"lane that was already there (tracked in #620). JET 0.12 still reports that finding, so the result is an expected broken test, not an unexpected pass. On LTS, JET resolves to 0.9.18 both before and after this change.Pre-existing failure (not addressed)
Root
GROUP=QAon Julia 1.10.12 fails on unmodified master with the same output. Aqua finds 1 method ambiguity:similar(::AbstractVectorOfArray, ::Type{T}, ::Tuple{Union{Integer,OneTo},Vararg{...}})(src/vector_of_array.jl:1157) vs Basesimilar(::AbstractArray, ::Type{T}, ::Tuple{Integer,Vararg{Integer}}).Julia 1.13 does not report it. It needs a separate fix (Aqua suggests defining
similar(::AbstractVectorOfArray, ::Type{T}, ::Tuple{Integer,Vararg{Integer}})) in its own PR.Not run
Nothing was skipped. Only the QA and NoPre groups were run; the other test groups were out of scope.
🤖 Posted by an AI agent — harness: Devin CLI 3000.11.92 (fix), Claude Code 2.1.300 (PR) · model: fusion-claude-opus-5-5-high-sidekick-swe-2-medium / claude-opus-5-5
Conversation: https://claude.ai/code/session_01VZjwf7Ux9YtTzwHGHMqnsq (fleet master)
🤖 Generated with Claude Code
Independent review (added by the fleet master)
Risk assessment
lib/RecursiveArrayToolsArrayPartitionAnyAll/test/qa/Project.toml,lib/RecursiveArrayToolsRaggedArrays/test/qa/Project.toml,lib/RecursiveArrayToolsShorthandConstructors/test/qa/Project.toml,test/NoPre/Project.toml; JET 0.12 may expose QA reports. No runtime source or public API changes.gh pr diffshows 4 JET compat append(s) inlib/RecursiveArrayToolsArrayPartitionAnyAll/test/qa/Project.toml,lib/RecursiveArrayToolsRaggedArrays/test/qa/Project.toml,lib/RecursiveArrayToolsShorthandConstructors/test/qa/Project.toml,test/NoPre/Project.toml; all existing bounds retained; no other changed lines, source edits, silencing, sources/path edits, or other dependency edits.gh pr checks: QA pending — no QA job reported yet; test discovery/workflows are queued or running. Local tests not run; PR body not read.🤖 Section added by an AI agent — harness: Claude Code 2.1.300 · model: claude-opus-5-5 (review by codex-cli, gpt-6.1-sol)
Conversation: https://claude.ai/code/session_01VZjwf7Ux9YtTzwHGHMqnsq