Repository navigation
fix: resolve ArrayPartition ambiguity QA - #648
Merged
ChrisRackauckas merged 1 commit intoAug 26, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://chatgpt.com/codex/tasks/019f4028-d2ae-7a12-aff0-7d996bd9c791
ChrisRackauckas
marked this pull request as ready for review
August 26, 2026 09:32
ChrisRackauckas
added a commit
that referenced
this pull request
Nov 2, 2026
…n Julia 1.10 (#678) * Fix method ambiguity in similar(::AbstractVectorOfArray, ::Type, dims) on Julia 1.10 Making AbstractVectorOfArray <: AbstractArray (#547) made RAT's similar(VA::AbstractVectorOfArray, ::Type{T}, dims::Tuple{Union{Integer,Base.OneTo}, Vararg{...}}) ambiguous with Base.similar(a::AbstractArray, ::Type{T}, dims::Tuple{Integer, Vararg{Integer}}), a Base fallback method that exists on Julia 1.10/1.11 but was removed in 1.12. This was masked by the Aqua ambiguities exemption until #648 removed it, so GROUP=QA on Julia 1.10 (the "lts" CI matrix entry) started failing on master. Adds the more specific Integer-only method Aqua's own diagnostic suggested, mirroring the analogous pair of methods Base itself defines, resolving the ambiguity without an Aqua exclusion. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com> Agent-Harness: Claude Code Agent-Model: claude-sonnet-5 Agent-Session: https://claude.ai/code/session_01LPHREnnonfLg1VcE1EJovv * Add Core regression coverage for explicit similar dimensions Cover non-Int integer tuples and existing Int, empty and OneTo paths for VectorOfArray and DiffEqArray. The new test reports eight ambiguity errors without the dispatch fix on Julia 1.10 and passes 48 assertions with it; Julia 1.12 passes the same assertions before and after. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.163.0 Agent-Model: gpt-6.1-sol Agent-Session: local session, transcript /home/crackauc/sandbox/goals/performance/jobs/rat/qa-master/log-codex.txt on amdci2 * Clarify the similar dispatch intersection comment Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.163.0 Agent-Model: gpt-6.1-sol Agent-Session: local session, transcript /home/crackauc/sandbox/goals/performance/jobs/rat/qa-master/log-codex.txt on amdci2 --------- Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the broad Aqua ambiguity exemption with source-level method disambiguation.
ArrayPartitionnow has explicit intersections forcopyto!withAbstractVectorOfArray, and its generic factorization extension is narrowed to the tested QR/SVD paths instead of discovering and extending everyLinearAlgebra.Factorizationsubtype. No exports or reexports change.Please ignore until reviewed by @ChrisRackauckas.
Verification:
aqua_broken = (:ambiguities,)reported 12 ambiguities: threecopyto!intersections and nine generatedldiv!intersections.GROUP=QA julia +release --startup-file=no --project=. -e 'using Pkg; Pkg.test()'passed20/20.\n- Focusedtest/Core/linalg.jlpassed, includingVectorOfArray copy intersections(4/4). The new calls would dispatch ambiguously before the source definitions.\n- Runic check,typos, andgit diff --checkpassed.\n\nNot run: the full Core group was started after the test correction but did not produce a completed local summary in this runner session; the focused affected test file is green.\n\n🤖 Generated with Claude Code\nhttps://chatgpt.com/codex/tasks/019f4028-d2ae-7a12-aff0-7d996bd9c791