Rewrite HybridPSO L-BFGS with custom Strong Wolfe line search#90
Conversation
|
@ChrisRackauckas Can you have a look? |
|
I think we can make this more modular here. First, https://github.com/SciML/LineSearch.jl exists, so any line-search implementation should go there. I believe those line searches are GPU compatible. If not, we can have our own LS here. But the core (L)-BFGS algorithm should be simple, and I am not sure why a complete custom implementation will be better. NonlinearSolve.jl seems to have been a more modular solution, unless it wasn't performant enough. |
|
I was assuming this is the Linesearch repo https://github.com/JuliaNLSolvers/LineSearches.jl whole time which is not gpu-compatible and implemented it from scratch here :( |
|
What's the status? Is it ready to go? |
|
Hello, it will be ready after this merges (SciML/NonlinearSolve.jl#948) |
Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
8f713b3 to
186d488
Compare
|
@utkarsh530 Please take a look. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Replaced SimpleNonlinearSolve dependency with custom implementation: