Repository navigation
Keep OrdinaryDiffEqDefault precompile helpers local - #4074
ChrisRackauckas merged 1 commit into
Conversation
|
Terminal CI classification for head No package test body failed on this PR. Excluding Runic, all 124 failures stopped in resolution, source development, dependency installation, or package build before the workflow test step:
The 67 non-downgrade failures all explicitly report the current SciMLBase 3.39/3.40 resolver boundary. The 57 downgrade jobs stop inside the downgrade resolver with Local validation on the exact implementation plus validation-only #4066 remains green: Default Core 46/46, JET 1/1, Aqua/ExplicitImports 19/19, and changed-file Runic. No CI-only workaround or unrelated prerequisite is being folded into this focused PR. |
|
Added the packaging correction in Local verification on the exact updated tree:
The temporary registered-graph checkout was restored and removed after the test. The branch is clean and matches pushed head |
|
One-hour terminal CI audit for corrected head Exact breakdown:
The resolver boundary is fixed separately by rebased #4066 ( |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
528e9b0 to
ba616a1
Compare
Ignore until reviewed by @ChrisRackauckas.
Summary
OrdinaryDiffEqDefaultSciMLBase.AutoDePSpecializethrough its public ownerOrdinaryDiffEqCore.lorenz_oopaccessThe earlier version/floor commits were dropped during the rebase because current master already contains the required
OrdinaryDiffEqDefault2.4.2 release andOrdinaryDiffEqCore4.11 floor.Root cause
OrdinaryDiffEqDefaultreached into private workload fixtures defined byOrdinaryDiffEqCore. The QA exception covered the original four names, but commit5d640b89a756fd0c81e86f2a09b91862a85be555addedlorenz_prefandlorenz_pref_paramswithout extending the exception. Its parentf06fd803209efb1fae0f5130c70574546f1bd7bchas no unignored private accesses; the commit has exactly those two.Adding another exception would preserve the private dependency. The workload RHS functions are tiny and package-specific, so this copies them locally and lets the public-access QA run without a Lorenz allow-list.
Validation
Rebased onto current upstream master
a7080c6f6d992edee79fa40450e0bd6eb0b8f735.GROUP=OrdinaryDiffEqDefault_QA: JET 1/1; Aqua 18 passed and 1 errored onlorenz_pref/lorenz_pref_paramsGROUP=OrdinaryDiffEqDefault_QA: JET 1/1; Aqua 19/19GROUP=OrdinaryDiffEqDefault_Core: Default Solver Tests 46/46Follow-up audit
Other solver sublibraries have their own explicit exceptions for the same Core workload fixtures. They are independent packages and are intentionally left for separate focused cleanup PRs.