remove redundant controller divisions#3745
Open
oscardssmith wants to merge 3 commits into
Open
Conversation
ChrisRackauckas
approved these changes
Jun 11, 2026
Comment on lines
+984
to
+985
| This algorithm is gennerally less efficient than a PI controller, but is used in adaptive order methods | ||
| (e.g. AdaptiveRadau) where a simpler stepsize controller makes an order controller eaiser. |
Member
There was a problem hiding this comment.
That's not true though? This isn't a Proportional Controller, it's a PredictiveController which is different.
Member
Author
There was a problem hiding this comment.
PI is our default controller though, it's just the 2nd part that is wrong, right?
Member
There was a problem hiding this comment.
It's not generally less efficient for all solvers, and it's not used with AdaptiveRadau
Member
Author
There was a problem hiding this comment.
what solvers is it more efficient for? I don't think we use it by default for any of them.
Member
There was a problem hiding this comment.
we probably should use them on some sdirks
Member
There was a problem hiding this comment.
It attempts to predict Newton instabilities, so possibly all. It's just an underexplored topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were doing a lot of divisions for no reason. Doing things in terms of
dt_factor instead ofinv(dt_factor)` maeks the math a lot nicer.