Support better logging for singular cases in integration#3731
Open
Shreyas-Ekanathan wants to merge 5 commits into
Open
Support better logging for singular cases in integration#3731Shreyas-Ekanathan wants to merge 5 commits into
Shreyas-Ekanathan wants to merge 5 commits into
Conversation
Comment on lines
+653
to
+654
| for i in axes(jac, 1), j in axes(jac, 2) | ||
| if !isfinite(jac[i, j]) || abs(jac[i, j]) > 1e6 |
Contributor
There was a problem hiding this comment.
If jac is a sparse matrix, then this will be super expensive. jac[i,j] triggers a lookup on every call and we even iterate over all zeros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Allows SciMLBase to freshly calculate the Jacobian for most accurate analysis. Supports SciML/SciMLBase.jl#1379