This repository was archived by the owner on Dec 29, 2025. It is now read-only.
Open
Conversation
Contributor
|
Just noticed that one commit includes the dependency issue discussed in #35. We should adapt that here as well. |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 41.09% 45.20% +4.10%
==========================================
Files 6 6
Lines 73 73
==========================================
+ Hits 30 33 +3
+ Misses 43 40 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
pzimbrod
suggested changes
May 27, 2022
Project.toml
Outdated
| CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba" | ||
| FFTW = "7a1cc6ca-52ef-59f5-83cd-3a7055c09341" | ||
| Flux = "587475ba-b771-5e3f-ad9e-33799f191a9c" | ||
| MAT = "23992714-dd62-5051-b70f-ba57cb901cac" |
Contributor
There was a problem hiding this comment.
Should go under [extras], not here as we use it only for testing
pzimbrod
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for forward pass, gradient and training