Raise ModelingToolkit 11.x test floor to 11.21 - #117
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
ModelingToolkit 11.0.0 fails to precompile on Julia 1.10 with UndefVarError: ispublic not defined. 11.21 is the first 11.x series floor used elsewhere that loads. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
11.21 is still unsatisfiable against this package's |
Member
Author
|
Superseded by #118 ( Please ignore this until reviewed by @ChrisRackauckas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed
Pure
[compat]lower-bound bump:ModelingToolkit = "9, 10, 11"→ModelingToolkit = "9, 10, 11.21"No library code or package version changed.
Why
A declared ModelingToolkit 11.x floor of
11pins 11.0.0 under julia-downgrade-compat. On Julia 1.10 that release fails to precompile:Isolated Julia 1.10.11:
Pkg.add(name="ModelingToolkit", version="11.0.0")resolves, then precompile dies (tree-shazsgrz). 11.1.0 still hitsispublic. 11.21.0 loads (same floor as CellMLToolkit / Corleone / CatalystNetworkAnalysis).Verification
UndefVarError: ispublicusing ModelingToolkitOKNot verified: a live
julia-downgrade-compatrun on this checkout after the bump.