Repository navigation
Drop SparseConnectivityTracer so docs can use LogExpFunctions 1 - #1201
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
SparseConnectivityTracer through 1.2.2 WeakCompat-pins LogExpFunctions to 0.3, which is unsatisfiable against NonlinearSolveBase LogExpFunctions = "1". No live SCT release allows LEF 1, and SCT is not SciML-owned. Remove SCT from the docs env and FirstOrder tests. Use DifferentiationInterface.DenseSparsityDetector (already a docs/test dep) for executed sparsity examples and tests. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Closing. Do not drop SparseConnectivityTracer from docs/tests. The pin is a stale SCT compat bound, not an API break. Upstream: JuliaDiff/SparseConnectivityTracer.jl#327 |
Contributor
|
SpaseConnectivityTracer.jl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop SparseConnectivityTracer from the docs environment and FirstOrder tests so NonlinearSolveBase can keep
LogExpFunctions = \"1\".Follow-up to the bound-only workaround in #1200 (leave that PR). After #1198, docs CI failed with:
Root cause
NonlinearSolveBase depends on
LogExpFunctions(logistic/logitin bounds transforms) with compat"1". Docs and FirstOrder tests also depended on SparseConnectivityTracer. No live SCT version allows LogExpFunctions 1:0.6.5 – 0.6.x0.3.28-0.31.xincluding latest1.2.2(2026-06-24)0.3.28-0.3Confirmed on SCT
main(LogExpFunctions = \"0.3.28\"). SCT is adrhill/SparseConnectivityTracer.jl; Chris is not an owner/maintainer/top contributor (adrhill 184, gdalle 34, …), so this is not filed upstream from here.What changed
Replace executed
TracerSparsityDetectorusage withDifferentiationInterface.DenseSparsityDetector(already a docs/test dependency; Symbolics 7.25+ would also allow LEF 1, but is not a docs dep). NSB stays onLogExpFunctions = \"1\".docs/Project.tomlSparseConnectivityTracerdocs/src/basics/sparsity_detection.mdDenseSparsityDetectorinstead of SCTdocs/src/tutorials/large_systems.mdDenseSparsityDetectorin executed examples; drop tracer-vs-DI comparisondocs/src/tutorials/snes_ex2.mdlib/NonlinearSolveFirstOrder/Project.tomlsparsity_tests__item{1,2}.jl,rootfind_tests__item19.jlDenseSparsityDetectorUser-facing:
NonlinearSolve+SparseConnectivityTraceris still unsatisfiable until SCT allows LogExpFunctions 1. Docs now demonstrateDenseSparsityDetector/SymbolicsSparsityDetectorinstead. Inlininglogistic/logitin NSB to drop the LEF dep entirely would restore SCT coexistence without waiting on adrhill; not done here.Verification (Julia 1.10.11)
Fresh docs resolve (no Manifest):
FirstOrder test env (after dropping SCT extra):
LogExpFunctions=1.0.1, SCT not in graph.Sparsity tests (local env,
DenseSparsityDetector):Docs build:
julia +1.10 --project=docs docs/make.jl→DOCS_MAKE_EXIT:0(Documenter HTML rendered; deploy skipped locally).Runic.jl
--inplaceon the three test files; no further diff.Not verified: GPU, downstream IntegrationTest, full FirstOrder Core (Enzyme/Zygote paths beyond item19), allowed-to-fail jobs.
This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code