Repository navigation
Raise LinearSolve sublibrary floor to 5.4 - #1165
Merged
ChrisRackauckas merged 1 commit intoAug 14, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
NonlinearSolveBase already requires LinearSolve 5.4 (SciML#1163). The FirstOrder and QuasiNewton sublibraries still declared LinearSolve 5, so Downgrade Sublibraries pinned 5.0.0 and Pkg.test failed as unsatisfiable. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 14, 2026 14:32
Member
Author
|
Independent clean-master validation of the merged floor alignment:
The exact assigned clean-master failures were: |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.
Follow-up to #1163, which raised the LinearSolve floor to 5.4 in NonlinearSolve and NonlinearSolveBase. The FirstOrder and QuasiNewton sublibraries were left at
LinearSolve = "5".What changed
Pure
[compat]lower-bound bump in two independently tested sublibraries:lib/NonlinearSolveFirstOrder/Project.toml:LinearSolve = "5"→"5.4"lib/NonlinearSolveQuasiNewton/Project.toml:LinearSolve = "5"→"5.4"No solver code, tests, or package versions were changed.
Why
Downgrade Sublibrarieson master is red while the matching parentDowngradeand latestCI (NonlinearSolve)runs are not. The failing jobs are only:lib/NonlinearSolveQuasiNewton)lib/NonlinearSolveFirstOrder)Downgrade pins each sublibrary's declared LinearSolve floor. With
"5"that is LinearSolve 5.0.0, which cannot satisfy in-tree NonlinearSolveBase (LinearSolve = "5.4"):Verification
Julia 1.10.11,
Pkg.developof each sublibrary, thenPkg.add(name="LinearSolve", version=...):Not verified here: the full Core/QA/GPU test groups, or whether other sublibraries have similar floors (only these two jobs were red on the latest Downgrade Sublibraries run).
Stale related PR: #1143 (parent-only LinearSolve 5.4 bump; superseded by #1163).