Skip to content

Remove stale SCCNonlinearSolve Reexport dependency - #1131

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/remove-scc-stale-reexport
Jul 30, 2026
Merged

ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/remove-scc-stale-reexport

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Ignore this PR until it has been reviewed by @ChrisRackauckas.

Summary

  • remove the unused Reexport dependency from SCCNonlinearSolve
  • remove its now-stale compat entry
  • keep Aqua's stale-dependency check strict; no ignore or allowlist is added

This is a metadata-only cleanup with no source or public-API behavior change.

Root cause

Reexport has been listed in SCCNonlinearSolve/Project.toml since the package was created in bec0bf27a, but SCCNonlinearSolve has never imported or used it. The stale dependency was masked while SciMLBase 3.39.1 incidentally loaded Reexport itself. SciMLBase 3.40.0 no longer does, so Aqua correctly exposes the SCC package's unused direct dependency.

The runtime boundary on clean NonlinearSolve master (cb25573a1) is exact:

  • SciMLBase 3.39.1: official SCCNonlinearSolve_QA passes 20/20
  • SciMLBase 3.40.0: official SCCNonlinearSolve_QA has 19 passes and one stale-Reexport failure

A SciMLBase history bisect identifies b9c3507a (Make strict QA owner-contract clean) as the first commit that removes SciMLBase's Reexport dependency/import and therefore exposes the latent SCC metadata defect.

Validation

With Julia 1.12.6 and SciMLBase 3.40.0:

  • NONLINEARSOLVE_TEST_GROUP=SCCNonlinearSolve_QA julia +1.12 --project=. -e 'using Pkg; Pkg.test()' — 20/20 pass
  • NONLINEARSOLVE_TEST_GROUP=SCCNonlinearSolve_Core julia +1.12 --project=. -e 'using Pkg; Pkg.test()' — 41/41 pass
  • whole-repository julia +1.12 -m Runic --check --diff . — clean

Copy link
Copy Markdown
Member Author

Hosted target-matrix validation is green:

  • SCCNonlinearSolve_Core, Julia 1.10: passed (3m51s)
  • SCCNonlinearSolve_Core, Julia 1.12: passed (5m35s)
  • SCCNonlinearSolve_Core, Julia 1.13-rc1: passed (5m50s)
  • SCCNonlinearSolve_QA, Julia 1.12: passed (5m26s)
  • SCC sublibrary downgrade: passed (4m27s)
  • complete Sublibrary CI workflow: passed

This matches the local boundary and validation: clean master with SciMLBase 3.40.0 failed QA 19/20 before this two-line metadata fix, while this branch passes QA 20/20 and Core 41/41 with SciMLBase 3.40.0. No QA ignore or allowlist was added.

The remaining active jobs are repository-wide downstream integration and the long NonlinearSolveFirstOrder downgrade lane; they do not exercise the removed SCC dependency directly and are being monitored/classified separately.

Copy link
Copy Markdown
Member Author

Hosted CI is now terminal. The SCC-specific validation remains fully green: QA on Julia 1.12, Core on Julia 1.10/1.12/1.13-rc1, SCC downgrade, and the complete sublibrary workflow all passed. Runic, docs, root downgrade, and all sublibrary downgrade jobs also passed.

The repository-wide Integration workflow has five passing lanes and two failing ModelingToolkit lanes. Both failures have the same unrelated DDE dependency-boundary cause:

  • ModelingToolkit/Initialization: 765 passed, 9 errored, 12 broken
  • ModelingToolkit/InterfaceII: 972 passed, 1 errored, 7 broken; the sole error is DDESystem Test
  • Both resolved DelayDiffEq v6.1.0 with OrdinaryDiffEqCore v4.11.0 and fail when DelayDiffEq calls the pre-limiter DEOptions constructor.
  • The corresponding Use public APIs for AutoDePSpecialize wrappers #1129 jobs failed with the same package pair, constructor MethodError, and counts before this branch existed.
  • The registry correction is tracked by Retroactively cap DelayDiffEq at OrdinaryDiffEqCore 4.8.0 JuliaRegistries/General#162781, which retrocaps DelayDiffEq 6.0–6.1 at OrdinaryDiffEqCore 4.8.0 and currently has green Julia 1.3–1.12 checks.

No SCC-specific or changed-file failure remains.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude
ChrisRackauckas-Claude force-pushed the agent/remove-scc-stale-reexport branch from 9fe8bef to 0ad4498 Compare July 30, 2026 13:33

Copy link
Copy Markdown
Member Author

Rebased onto current master at 061cac4fd after #1130 merged. The branch still contains exactly the two dependency-declaration deletions; new head is 0ad4498d6142cc983e122449bb5682b0f4a8d64a.

Post-rebase local validation on Julia 1.12 / SciMLBase 3.40.0:

  • SCCNonlinearSolve_QA: 20/20 passed
  • SCCNonlinearSolve_Core: 41/41 passed (14+3+6+13+5)
  • repository-wide Runic --check --diff .: passed

Before the lease-protected update, I fetched the fork and confirmed its branch still contained only the prior head 9fe8befb; no contributor commits were overwritten.

ChrisRackauckas-Claude commented Jul 30, 2026 •

Copy link
Copy Markdown
Member Author

Post-rebase hosted target matrix is fully green at 0ad4498d:

  • SCCNonlinearSolve_Core, Julia LTS: passed (6m24s)
  • SCCNonlinearSolve_Core, Julia 1.12: passed (7m59s)
  • SCCNonlinearSolve_Core, Julia pre-release: passed (8m42s)
  • SCCNonlinearSolve_QA, Julia 1.12: passed (8m10s)
  • SCC sublibrary downgrade: passed (6m54s)
  • root downgrade: passed (12m54s)
  • complete Sublibrary CI workflow: passed

The affected-package validation therefore remains green both locally and on the rebased hosted head.

Copy link
Copy Markdown
Member Author

Scheduled CI/ancestry audit completed at 2026-07-30 10:07 EDT:

  • PR is open, draft, and mergeable.
  • Exact head: 0ad4498d6142cc983e122449bb5682b0f4a8d64a; fork remote matches exactly.
  • Freshly fetched upstream/master is 061cac4fd; branch is 1 commit ahead and 0 behind.
  • Worktree is clean; diff is exactly 1 file with 2 deletions.
  • Required Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> trailer is present exactly.
  • Check rollup: 21 success, 3 skipped, 7 in progress, 0 failures.
  • SCC QA, all three SCC Core versions, SCC downgrade, Runic, root downgrade, documentation, and complete Sublibrary CI are green.

The seven remaining jobs are six repository-wide downstream integration lanes and the unrelated NonlinearSolveFirstOrder downgrade lane. No affected-package blocker remains.

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 30, 2026 14:33
@ChrisRackauckas
ChrisRackauckas merged commit 451a023 into SciML:master Jul 30, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants