Repository navigation
Fix QA: approve the tovar public reexport - #5123
Merged
ChrisRackauckas merged 1 commit intoSep 13, 2026
Merged
Conversation
SciML#5120 declared `tovar` public in ModelingToolkitBase without adding it to `REEXPORTED_API`, so the outer `No unapproved public reexports` audit fails on master (Tests / QA on 683dd70). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Agent-Harness: Claude Code 2.1.269 Agent-Model: claude-fable-5-1 Agent-Session: https://claude.ai/code/session_01ReTWnXHfsN2gZziNYQaCAQ Claude-Session: https://claude.ai/code/session_01ReTWnXHfsN2gZziNYQaCAQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5120 declared
tovarpublic in ModelingToolkitBase without adding it to the version-controlledREEXPORTED_APIaudit list intest/qa/qa.jl, so the outer QA group fails on master: theTests / QA (Julia 1)job on 683dd70 reportsNo unapproved public reexports: Evaluated: isempty([:tovar]). One-line allow-list entry, same shape as #5116.Verification
julia --startup-file=no --project=test/qa -e 'using Pkg; Pkg.instantiate(); include("test/qa/qa.jl")'on this branch (Julia 1.12.4):The same command on master (as of 683dd70, run from the branch of #5117 which only adds its own names to the list) fails only on
:tovar:Nothing else touched; no runtime code changes.
🤖 Generated with Claude Code (Claude Code 2.1.269, model: claude-fable-5-1)
https://claude.ai/code/session_01ReTWnXHfsN2gZziNYQaCAQ