Repository navigation
Raise LinearSolve and DiffEqBase downgrade floors - #4964
Merged
ChrisRackauckas merged 1 commit intoAug 14, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Downgrade on master installs LinearSolve 5.2.0 and DiffEqBase 7.10.0. LinearSolve 5.0–5.3 use a bare `issquare` in the ForwardDiff extension, and DiffEqBase 7.10's DEVerbosity lacks `symbolic_diagnostic` that SciMLBase 3.44 reads. Raise those floors to 5.4 and 7.12. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed and why
Pure
[compat]lower-bound bumps so Downgrade CI cannot pin the versions that are red on current master:Project.tomlDiffEqBase7.4.27.12Project.tomlLinearSolve3.66, 4, 53.66, 4, 5.4lib/ModelingToolkitBase/Project.tomlDiffEqBase7.4.27.12lib/ModelingToolkitBase/Project.tomlLinearSolve3.19.2, 4, 53.19.2, 4, 5.4No solver code, tests, or package versions were changed.
Default-branch evidence
On
720acb0458(currentupstream/master):This is not #4911 (
@test_brokenremake inference). The current master failures are different.Parent Downgrade (InterfaceI)
Installed
LinearSolve v5.2.0. The only test error:Same LinearSolve 5.0–5.3 ForwardDiff-extension bug as SciML/NonlinearSolve.jl#1143 / SciML/NonlinearSolve.jl#1163:
ext/LinearSolveForwardDiffExt.jlcalls bareissquareuntil 5.4 (using SciMLOperators: issquare).MTKBase Downgrade
Installed
DiffEqBase v7.10.0+SciMLBase v3.44.0. The only test error:symbolic_diagnosticexists onDEVerbosityfrom DiffEqBase 7.12.0; SciMLBase 3.38+ (including the MTKBase floor 3.44) reads that field.Parent also depends on ModelingToolkitBase
1.63(SciMLBase3.44), so after the LinearSolve bump the parent job would hit the sameDEVerbosityhole. Both floors go in this PR.Verification (Julia 1.10.11)
Isolated Dual-
LinearProblemjacobian, sameissquarepath:Isolated
DEVerbosityfield access:Developed this branch + added current LinearSolve/DiffEqBase:
Pinning DiffEqBase 7.10.0 against the new MTKBase floor:
LinearSolve is an extra, so a top-level
Pkg.add(LinearSolve@5.2)against a developed parent does not apply extras[compat]. Downgrade CI merges extras and will pin5.4.0after this change. The Dual jacobian above is the fail-before / pass-after for that extra.What was not verified
GROUP=InterfaceI/ MTKBaseInitializationsuite under a julia-downgrade-compat pin (the isolated Dual /DEVerbositypaths are the two CI exceptions).pre.@test_brokeninference issue; not touched.Reviewer notes
DEVerbosityhassymbolic_diagnostic.