Repository navigation
Give the POD reduced system its own time span - #205
Merged
ChrisRackauckas merged 1 commit intoSep 9, 2026
Merged
Conversation
deim already inherited a time span; pod did not, so the POD Galerkin examples still had to repeat the full problem's. Thread tspan through _pod into the shared assembler, from prob.tspan for the problem method and get_tspan(sys) for the system method, and drop the now-redundant argument from the README, the docstring and the FitzHugh-Nagumo test. Completes the ModelOrderReduction side of SciML#29, in 1.0.0 before release. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Agent-Harness: Claude Code 2.1.263 Agent-Model: claude-opus-5 Agent-Session: https://claude.ai/code/session_01H5RuLDtEazwTKPkNbPeZVu Claude-Session: https://claude.ai/code/session_01H5RuLDtEazwTKPkNbPeZVu
ChrisRackauckas
marked this pull request as ready for review
September 9, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until reviewed by @ChrisRackauckas.
Finishes the ModelOrderReduction side of #29, in 1.0.0 before it is released. No version bump: General still has 0.1.11, so 1.0.0 has never shipped and this lands as part of it.
#181 gave
deiman inherited time span, butpodarrived in parallel through #202 and did not get one. So the POD Galerkin example in the README still read:which is exactly the out-of-band time-span threading issue 29 is about.
podnow inherits one on the same terms asdeim:What changed
_podtakes atspanand forwards it into the shared_assemble_reduced_system, on both the array and the compiled-fallback paths. That function already accepted the keyword, so this is a thread-through rather than new machinery.prob.tspan, the interval the reduction was trained on. The system method usesget_tspan(sys). A source without a span still yields a reduced system without one, rather than a fabricated interval, and passing one explicitly still overrides.poddocstring example, and the FitzHugh-Nagumo DEIM test drop the now-redundant argument. That test now assertsdeim_prob.tspan == full_prob.tspan, so the inherited span is checked end to end through MethodOfLines rather than merely being unused.AGENTS.mdrecords the convention. Its note from Give the reduced system its own time span #181 never actually reached main: the squash merge of that PR did not carry the file, which I confirmed withgit log -S. This restores it covering both entry points, and corrects a now-stale line claiming a time span must be passed to build a problem.Two
full_problem.tspanuses remain intest/pod.jl. They are deliberate: they exercise the explicit-override path, which still has to work.Verification
Julia 1.12.7, against ModelingToolkit 11.42.0 and ModelingToolkitBase 1.69.0 from the registry.
The new
podtestset covers all four cases: inherited from the problem, inherited from the system, absent when the source has none, and the problem building without an explicit span.Runic --check .,typos, andgit diff --checkall exit 0.Not verified
GROUP=QAand the docs build were not re-run; this adds no public name and changes no import. The README edit is not executed by the docs build.The rest of the chain, for context
ModelingToolkitBase 1.69.0 added the
Systemfield, ModelingToolkit 11.42.0 raised the floor that guarantees it, and PDEBase 0.1.35 sets the span on the systemsymbolic_discretizereturns, so a MethodOfLines discretization carries the PDE's owntdomain. All three are registered. SciML/MethodOfLines.jl#685 raises its floors to match and is still open.🤖 Generated with Claude Code
https://claude.ai/code/session_01H5RuLDtEazwTKPkNbPeZVu