Repository navigation
Make MOLFiniteDifference and PseudospectralDiscretization box discretizations - #729
Draft
xtalax-droid wants to merge 1 commit into
Draft
xtalax-droid wants to merge 1 commit into
xtalax-droid wants to merge 1 commit into
Conversation
…izations Both now subtype PDEBase.AbstractBoxDiscretization (FEM spec M0, section 4.2) so PDEBase can lower boundary conditions for box discretizers. Needs a PDEBase release containing the type (SciML/PDEBase.jl#143); compat is not bumped here. Agent-Harness: Claude Code 2.1.310 Agent-Model: claude-sonnet-5-5 Agent-Session: 6c520c71-764b-4a7e-a484-62d5a95bcfa1 Agent-Review: unreviewed Co-authored-by: Claude Code <agent@noreply.juliahub.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOLFiniteDifferenceandPseudospectralDiscretizationnow subtypePDEBase.AbstractBoxDiscretizationinstead ofAbstractEquationSystemDiscretization. This lets PDEBase's box-specific boundary lowering and classifier hooks apply to them (M0 of the FiniteElementMethod design, section 4.2). There is no behaviour change.Depends on SciML/PDEBase.jl#143 (not merged, not released). Do not merge until a PDEBase release containing
AbstractBoxDiscretizationis registered and this PR's[compat]for PDEBase is raised to it. Until then CI is expected to fail withUndefVarError: AbstractBoxDiscretization;Project.tomlis deliberately unchanged here because the release number is not known.Tests, run against PDEBase.jl#143 at 2d5d5ba6 (developed into a scratch copy):
test/test_groups.tomlexcept GPU and NeuralNets) all pass.AbstractBoxDiscretization.to_box_bcsis stubbed as pending (@test_broken), becauseto_box_bcsis not in Discretization failed #143 yet.srcand the touched test files.Codex review: the one finding is the release/compat gating above.
🤖 Posted by an AI agent · harness: Claude Code 2.1.310 · model: claude-sonnet-5-5
Review: unreviewed
Session: 6c520c71-764b-4a7e-a484-62d5a95bcfa1