Repository navigation
Rewire Brusselator, Nonlinlap_ADV, and MOL_Interface2 into CI - #710
Conversation
These groups are dispatched in runtests.jl but were omitted from test_groups.toml, so grouped-tests CI never scheduled them. Local runs on julia +1 and +lts now pass within minutes, so declare them with the same versions as neighbouring groups. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.10.01-14929f9 Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/mol-groups/log.txt on amdci2
Independent review (Devin CLI 3000.11.3, model fusion-claude-opus-5-5-high-sidekick-swe-2-medium): MERGE, risk low. Full reviewVERDICT: MERGE PR: #710 (no linked issue; references closed issues 509/515/521 and merged PRs 573/576). Blocking findingsNone. Non-blocking findings
All six jobs finished in 6–18 min of wall time, well under the 120-min job timeout. That timeout is what now protects against the old 6-hour stalls from issues 509/515. What I ran
What I did not verify
Links
🤖 Posted by an AI agent — harness: Devin CLI 3000.11.3 (review), Claude Code 2.1.285 (posting) · model: fusion-claude-opus-5-5-high-sidekick-swe-2-medium |
Summary
Brusselator,Nonlinlap_ADV, andMOL_Interface2are dispatched intest/runtests.jlbut were never declared intest/test_groups.toml, so SciML grouped-tests CI never scheduled them. Brusselator and MOL_Interface2 were previously removed from the hard-coded Tests.yml matrix for 6h stalls (#509, #515, #521; now closed). Nonlinlap_ADV was never in that per-group matrix:git log -S Nonlinlap_ADVshows it was only reachable viaGROUP=All/ individualGROUP=, and was omitted whentest_groups.tomlbecame the matrix source (#573 / #576). This PR adds all three withversions = [\"lts\", \"1\", \"pre\"]matching neighbouring groups. Test contents are unchanged.Verification
Env:
JULIA_CONDAPKG_BACKEND=Null JULIA_PYTHONCALL_EXE=/usr/bin/python3, local depot under the job scratch dir. Commands (one Julia process at a time):(LTS needed a fresh
Pkg.resolve()after removing the 1.13 Manifest; not committed.)Log tails:
Group ↔ toml check after this change: every
FUNCTIONAL_GROUPSentry is a toml key. Toml keys not inFUNCTIONAL_GROUPSremain intentional:Components 32-bit(alias),NeuralNets(own env),QA(qa path).Not verified
+prechannel (declared like neighbours; not run locally)GROUP=All/ Downgrade workflowsPlease ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
@test_brokencases unchanged).test/test_groups.toml). No library or test-body changes.Pkg.test()runs above; issues Brusselator and MOL_Interface2 tests stall for 6+ hours in CI #509/MOL_Interface2 test group stalls for 6+ hours #515/Re-enable Brusselator CI tests #521 closed as resolved.Harness: Cursor Agent CLI 2026.10.01-14929f9; model: auto; transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/mol-groups/log.txt on amdci2
Made with Cursor
Independent review: Devin Fusion (fusion-claude-opus-5-5-high-sidekick-swe-2-medium) rated it low, verdict MERGE: #710 (comment)