Repository navigation
Widen QA env JET compat to admit 0.12 for Julia 1.13 - #105
Merged
Merged
Conversation
The QA group's test/qa env pins JET = "0.9, 0.10, 0.11" directly, and JET < 0.12 does not support Julia 1.13, so the QA lane on julia "1" fails Pkg resolve with an unsatisfiable-requirements error. Admitting 0.12 lets 1.13 pick JET 0.12.x while older Julia versions still resolve to 0.9-0.11. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.11.228 Agent-Model: swe-2-high Agent-Session: local job 104-devin (no session URL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
test/qa/Project.tomlpinsJET = "0.9, 0.10, 0.11"directly in its[compat], and JET < 0.12 does not support Julia 1.13, so theTests - QA (Julia 1)lane fails atPkg.resolve(). This widens the entry to"0.9, 0.10, 0.11, 0.12". Unlike the sibling fix in SciML/DeepEquilibriumNetworks.jl#254, the pin here is the QA env's own compat entry, not LuxTestUtils (this repo does not depend on LuxTestUtils) — confirmed by the resolver messagerestricted to versions 0.9 - 0.11 by project.Verification
Fail before (unfixed
test/qa/Project.toml, Julia 1.13.1)In a scratch copy of the
test/qaenv:Pass after (Julia 1.13.1)
Same command with the fix resolves
JET v0.12.3(alongside Aqua v0.8.18, SciMLTesting v2.13.3, MATLABDiffEq dev'ed to the branch).lts (Julia 1.10.12)
The same scratch-env resolve on
julia +ltssucceeds and picksJET v0.9.18, so the widened range does not break the lts lane.Not verified
GROUP=Core(interface + MATLAB runtime tests) was not run locally; it is untouched by this one-linetest/qacompat change. No MATLAB or Octave runtime is installed on this machine, andtest/matlab_runtime_tests.jlalready gates onmatlab_engine_available().typosover the diff: clean. No Julia source or docs touched, so Runic and the docs build are no-ops.For the reviewer
0.12only, not the already-registered0.13.x, matching the proven sibling fix; JET 0.13 can be admitted in a follow-up once QA is green on 1.13.Risk assessment
[compat]bound intest/qa/Project.toml; no package code or public API touched. Worst case: a JET 0.12 finding appears on CI that the local run did not show.GROUP=QA54/54 pass on Julia 1.13.1; lts resolve still picks JET 0.9.18.Closes #104
🤖 Posted by an AI agent — harness: Devin CLI 3000.11.228 · model: swe-2-high
Conversation: local job 104-devin (no session URL)
Risk assessment (independent review, Codex gpt-6.1-sol, head 95ff400)
test/qa/Project.toml:11; existing JET ranges remain accepted. No public API, numerical behavior, supported-platform removal, new dependency, or licensing change. No new public names requiring documentation or SemVer bump; no skipped or loosened tests.git diff origin/HEAD...HEAD), QA runner, and CI configuration; verified HEAD is95ff4006580a0c47674bafffedef39afe5fb01a7and origin/HEAD isdfc7eb6573a20fa4f8acf35efc0f89962e6d019b.git diff --check origin/HEAD...HEADexited 0. Ran the sameusing Pkg; println("JULIA ", VERSION); Pkg.develop(path=ARGS[1]); Pkg.resolve(); Pkg.status()script against scratch exports of base and head, usingtimeout 3600, the prescribed depot, four threads, and installed Julia 1.13.1: base exited 1 with JET restricted to0.9 - 0.11versus Julia-compatible0.12.0 - 0.13.1(no versions left); head exited 0 and selected JET 0.12.3. Ran the same head-environment resolve using Julia 1.10.12 with--compiled-modules=no: exited 0, JET 0.9.18. Commands and output are reproducible withscratch/resolve.jl, the exportedscratch/baseandscratch/head, and logsscratch/base-resolve.log,scratch/head-resolve.log,scratch/lts-resolve.log. Read checks withgh pr view 105 --repo SciML/MATLABDiffEq.jl --json headRefOid,statusCheckRollup: all 11 reported checks/statuses succeeded. Read base/head run metadata and QA job logs through read-onlygh api: base QA fails with the same JET conflict; head QA installs JET 0.12.3 and reportsQA/qa.jl | 54 54 46.5s, followed byMATLABDiffEq tests passed. G1: not applicable (no numerical changes). G2: not applicable (no GPU/AD/Reactant/MPI changes); the changed QA environment is exercised successfully by exact-head CI. G3: not applicable (no shared-state/cache/threading/default changes).🤖 Posted by an AI agent — harness: Codex CLI · model: gpt-6.1-sol (independent review, submitted by sciml-submaster, Claude Code claude-sonnet-5-5)
Conversation: https://claude.ai/code/session_01379heia6cKWmdtNob6NGzg