Repository navigation
Import FunctionOperator from its owner in Core tests - #1132
Merged
ChrisRackauckas merged 1 commit intoAug 1, 2026
Merged
Conversation
SciMLBase v3.40.0 stopped re-exporting SciMLOperators, so the bare FunctionOperator calls in test/Core/default_algs.jl no longer resolve. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 1, 2026 10:37
Member
Author
|
Full No |
Member
Author
|
Note: this PR was opened with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.
Problem
GROUP=Corefails onmainin the "Default Alg Tests" safetestset:test/Core/default_algs.jlcallsFunctionOperator(...)at lines 167, 179 and 191 but only doesusing LinearSolve, RecursiveFactorization, LinearAlgebra, SparseArrays, Test.Root cause (not a LinearSolve commit)
git bisectover LinearSolve does not find a culprit — the name was never provided by LinearSolve itself.FunctionOperatorreached the test scope through@reexport using SciMLBase(src/LinearSolve.jl:94) becauseSciMLBase in turn did
@reexport using SciMLOperators. That re-export was removed bySciML/SciMLBase.jl@b9c3507 ("Make strict QA owner-contract clean", SciML/SciMLBase.jl#1472),
which shipped in SciMLBase v3.40.0. LinearSolve's compat is
SciMLBase = "3.33", so the failure appearedpurely from a dependency upgrade.
Evidence (all run locally):
So neither #1129 nor #1130 introduced it; those PRs were fixing other names hit by the same upstream change.
FunctionOperatorwas simply the next one to be missed.Fix
I swept every name that SciMLBase v3.39.1 exported and v3.41.0 no longer does (36 names, essentially the
SciMLOperators surface:
MatrixOperator,IdentityOperator,WOperator,cache_operator,issquare,update_coefficients!, ...) against all oftest/,src/,ext/.FunctionOperatorintest/Core/default_algs.jlwas the only remaining unqualified use; every other occurrence intest/alreadyhas an explicit
using SciMLOperators: ...(test/Core/basictests.jl:2-3,test/Core/traits.jl:4,test/Core/default_algs.jl:360), andsrc//ext/import from SciMLOperators directly.Local verification
julia --project=<env> test/Core/default_algs.jlon this branch (env = LinearSolve dev'd + RecursiveFactorization,SciMLOperators, StableRNGs, Test, LinearAlgebra, SparseArrays, Random; SciMLBase v3.41.0):
Same command on unmodified
mainerrors atdefault_algs.jl:167with theUndefVarErrorabove.A full
GROUP=Core julia --project=. -e 'using Pkg; Pkg.test()'run is in progress; I will post the result as acomment when it finishes.
Runic formatting checked on the touched file (
Runic.main(["--check", "test/Core/default_algs.jl"])-> exit 0).