Use SciMLTesting v1.2 (folder-based run_tests)#1044
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Use SciMLTesting v1.2 (folder-based run_tests)#1044ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Restructure test/ into group-named folders and replace the hand-written GROUP dispatch ladder in test/runtests.jl with SciMLTesting v1.2 run_tests in explicit-args mode. The sublibrary pre-step (LINEARSOLVE_TEST_GROUP routing to lib/*) is preserved verbatim; the root group dispatch (curated All = Core + LinearSolveSTRUMPACK, umbrella LinearSolveCUDA -> GPU, and all platform/version guards) is expressed via run_tests core/groups/qa/all/umbrellas. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2 model.
LinearSolve's root test harness has platform/version guards (
Base.Sys.islinux(),VERSION >= v"1.12", prerelease checks), a curatedAllgroup (Core + LinearSolveSTRUMPACK only), an umbrella alias (LinearSolveCUDA->GPU), and lib/* sublibrary dispatch viaLINEARSOLVE_TEST_GROUP. Folder-discovery mode cannot express these, so this uses SciMLTesting v1.2 explicit-argsrun_testsover group-named folders (the OrdinaryDiffEq-style monorepo shape).Changes:
test/runtests.jl: keeps the sublibrary pre-step (transitive[sources]develop walk on Julia <1.11 +withenv(LINEARSOLVE_TEST_GROUP) Pkg.test(sublib)) verbatim; replaces the rootif GROUP == ...ladder withrun_tests(; core, groups, qa, all=["Core","LinearSolveSTRUMPACK"], umbrellas=Dict("LinearSolveCUDA"=>["GPU"]), sublib_env="LINEARSOLVE_TEST_GROUP", lib_dir=...). Platform/version-guarded groups use thunks that gateactivate_group_envinside the guard (so the env is not instantiated on a platform/version where the group does not run, matching the old dispatch); unguarded dep-adding groups (GPU/Pardiso/HSL) useenv=specs.test/core->test/Core,test/strumpack->test/LinearSolveSTRUMPACK,test/nopre->test/NoPre, ...);test/pureumfpack.jlmoved intotest/LinearSolvePureUMFPACK/.test/qakept lowercase. Per-group[sources]paths are depth-preserved.SciMLTesting(+ compat1) to the root test target and to every@safetestset-running sub-envProject.toml; addedSafeTestsetsto those sub-envs that lacked it (their@safetestsetbodies dousing Test, SafeTestsetsin the activated env).Pkgis retained in the root test deps (the sublibrary pre-step still uses it).test/test_groups.tomlunchanged.Behavior preservation was verified by driving the real SciMLTesting v1.2.0
run_testsover every GROUP value on Julia 1.11 and 1.12: the fired group bodies, sub-env activations, and lib/* sublibrary routing (including<sublib>,<sublib>_QA,<sublib>_Core) match the old dispatcher exactly, including the Enzyme/ParU/Trim version guards and the linux/non-windows platform guards.Ignore until reviewed by @ChrisRackauckas.