Fix DefaultsLoading test: sparse BigFloat defaults to PureKLU (not Sparspak) since #1037#1043
Merged
ChrisRackauckas merged 2 commits intoJun 14, 2026
Conversation
… Sparspak SciML#1037 changed the default sparse LU for generic (non-BLAS) element types from SparspakFactorization to PureKLU (a hard dependency), removing the "SparspakFactorization required" error branch from `defaultalg`. The DefaultsLoading test still asserted that error was thrown when solving a sparse BigFloat problem before `using Sparspak`, so it failed on master with "No exception thrown" (defaults_loading.jl:30). Update the test to the new intended behavior: a generic-eltype sparse problem now routes to `KLUFactorization` and solves without Sparspak loaded. Closes the `@test_throws` into a positive assertion (defaultalg === KLUFactorization, solve returns Vector{BigFloat}). Fixes SciML#1042. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1042 — a stale test failing on
main/CI in theDefaultsLoadinggroup.Problem
test/defaultsloading/defaults_loading.jl:30asserted, via@test_throws, that solving a sparseBigFloatLinearProblembeforeusing Sparspakraises"SparspakFactorization required ... using Sparspak". That fails onmainwith "No exception thrown":Cause
#1037 (
52ebf258, "Default to PureKLU for generic-eltype sparse LU") intentionally changed the default sparse LU for generic (non-BLAS) element types fromSparspakFactorizationto PureKLU — a pure-Julia hard dependency — and removed the"SparspakFactorization required"error branch fromdefaultalg. So that error path is unreachable now, and the@test_throwsnever fires. The test simply wasn't updated alongside the routing change.Fix
Update the test to the new intended behavior: a generic-eltype (BigFloat) sparse problem routes to
KLUFactorizationand solves withoutusing Sparspak.Verification
Ran the full
test/defaultsloading/defaults_loading.jllocally (Julia 1.12 / Linux, withSparspak+STRUMPACK_jllavailable) — passes, no failures.Runic --checkclean.Please ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code