Normalize nopre -> QA (+ split AD/Enzyme)#1039
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
The root NoPre group mixed standard QA tooling (JET) with functional Enzyme/Mooncake/AllocCheck/StaticArrays tests. Per the fleet rule, split them (root package only; lib/* sublibraries are untouched and have no NoPre group): - QA (standard checks): now also carries JET. jet.jl moves from test/nopre into the existing test/qa env, whose Project.toml gains JET plus the deps jet.jl uses (ForwardDiff, RecursiveFactorization, LinearAlgebra, SparseArrays). The QA dispatch runs qa.jl and jet.jl. QA stays at versions ["lts","1"]. - AD (functional): mooncake/enzyme/static_arrays/caching_allocation_tests move from test/nopre into test/AD with the former nopre env minus JET. New [AD] group at versions ["lts","1"]; not run on prerelease. The Julia >= 1.12 Enzyme guard is preserved. The old [NoPre] key, test/nopre dir, and NoPre dispatch are removed. Test file bodies are unchanged (moved verbatim); only config/test-env files and the group dispatch were edited. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fleet-wide nopre/NoPre test-group normalization (policy: standard Aqua/JET/ExplicitImports checks live in the canonical
QAgroup; pre-incompatible functional/AD tests get their own content-named group). Root package only —lib/*sublibraries have noNoPregroup and are untouched.Survey result: the root
NoPregroup was MIXED — JET (standard QA) plus Enzyme/Mooncake/AllocCheck/StaticArrays functional tests — so it is SPLIT:jet.jlmoves fromtest/nopreinto the existingtest/qaenv; itsProject.tomlgains JET plus the depsjet.jluses (ForwardDiff, RecursiveFactorization, LinearAlgebra, SparseArrays). The QA dispatch runsqa.jlandjet.jl; QA stays atversions = ["lts","1"].mooncake.jl,enzyme.jl,static_arrays.jl,caching_allocation_tests.jlmove fromtest/nopreintotest/AD(former nopre env minus JET).[AD]atversions = ["lts","1"]; not run on prerelease. The Julia >= 1.12 Enzyme guard is preserved.The old
[NoPre]key,test/nopredir, and NoPre dispatch are removed. Onlytest_groups.toml,runtests.jl, and the two test-env files changed; test file bodies are unchanged (moved verbatim). No edits totest/core,test/hsl,test/pureumfpack, etc.Static-verified locally:
test_groups.tomlparses; both envProject.tomlfiles parse;runtests.jlpassesMeta.parseall; qa env has Aqua+JET, AD env has Enzyme+Mooncake and no JET.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code