Initialize HYPRE before creating objects when using plain Julia arrays#1001
Open
AJ0070 wants to merge 5 commits into
Open
Initialize HYPRE before creating objects when using plain Julia arrays#1001AJ0070 wants to merge 5 commits into
AJ0070 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This fixes a HYPRE initialization bug in the
LinearSolveHYPREExtpath for plain Julia matrix/vector inputs.Previously,
SciMLBase.initcould auto-constructHYPREMatrix/HYPREVectorbeforeHYPRE.Init()had been called. Since those constructors touch MPI internally, a serialsolve(prob, HYPREAlgorithm(...))call could fail with:Attempting to use an MPI routine (internal_Comm_size) before initializing or after finalizing MPICHThis PR initializes HYPRE before the auto-conversion path runs, while preserving the existing public API and solver behavior.
fixed #777
AI Disclosure: Used GPT 5.4