Repository navigation
Migrate QA to SciMLTesting 2.4 - #76
Merged
ChrisRackauckas merged 1 commit intoJul 22, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 22, 2026 14:48
This was referenced Jul 28, 2026
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/FunctionWrappersWrappers.jl
that referenced
this pull request
Jul 29, 2026
SciML#76 replaced the whole `run_qa(...)` call with a bare `run_qa(FunctionWrappersWrappers)`, which silently discarded the `all_qualified_accesses_are_public` ignore list it carried. The QA group has errored on `main` ever since with `NonPublicQualifiedAccessException` for `FunctionWrappers.FunctionWrapper` and `TruncatedStacktraces.@truncate_stacktrace`. This is invisible to `Pkg.test()`, which runs the curated default group; QA is not part of it. `:tail` is not restored: `Base.tail` is no longer reached, and ExplicitImports does not flag it. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Jul 29, 2026
…tructor (#79) * Restore the ExplicitImports ignores dropped in #76 #76 replaced the whole `run_qa(...)` call with a bare `run_qa(FunctionWrappersWrappers)`, which silently discarded the `all_qualified_accesses_are_public` ignore list it carried. The QA group has errored on `main` ever since with `NonPublicQualifiedAccessException` for `FunctionWrappers.FunctionWrapper` and `TruncatedStacktraces.@truncate_stacktrace`. This is invisible to `Pkg.test()`, which runs the curated default group; QA is not part of it. `:tail` is not restored: `Base.tail` is no longer reached, and ExplicitImports does not flag it. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> * Drop the dead TruncatedStacktraces dependency `@truncate_stacktrace` cannot fire in this package. TruncatedStacktraces sets `DISABLE = @load_preference("disable", true) || VERSION >= v"1.10"`, and the macro body is wrapped in `@static if !DISABLE`, so on Julia 1.10 and later it expands to nothing — and 1.10 is this package's floor. The `Base.show` method it is supposed to define has never existed on any Julia version we support, and the preference cannot override the version clause. Verified: `FunctionWrappersWrapper` contributes zero `Base.show` methods, and its type prints in full with no truncation. That makes the dependency dead weight, and it was the only reason the QA suite needed a `@truncate_stacktrace` ignore. Removing it is better than either ignoring the access or promoting the name upstream — the latter is impossible in any case, since SciML/TruncatedStacktraces.jl is archived and read-only. Only the `FunctionWrapper` ignore remains, and that one has a path out now: JuliaLang/FunctionWrappers.jl#35. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> * Document the explicit FunctionWrappersWrapper{FW, P, CS}(fw, cs) constructor `FunctionWrappersWrapper` is exported, so its inner constructor was already reachable as public API, but it carried no docstring — the only constructor of the type that did not. Downstream solver stacks construct through exactly this method, because supplying `FW`, `P` and `CS` directly keeps the wrapper type inferrable without relying on constant propagation through a keyword-argument frame, which the `argtypes`/`rettypes` and tuple constructors do. The docstring is attached with `@doc` on the method signature after the struct; a docstring written inside the struct body does not attach to the type's binding, so Documenter would never render it. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> --------- Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local validation
git diff --check: passedIgnore until reviewed by @ChrisRackauckas.