Enforce repository-wide strict API documentation QA - #267
Draft
ChrisRackauckas-Claude wants to merge 2 commits into
Draft
Enforce repository-wide strict API documentation QA#267ChrisRackauckas-Claude wants to merge 2 commits into
ChrisRackauckas-Claude wants to merge 2 commits into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Materialize CPU views before copying reduced Krylov operands to GPU storage, and cover the public expv path with a focused CUDA regression test. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Follow-up commit Local validation after the change:
The CUDA suite cannot run locally because this host has no NVIDIA device; the refreshed real-GPU CI job is authoritative. The unrelated Windows failure is an unchanged unseeded static-Jacobian test and was not altered in this docs/QA PR. |
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
StegrWorkimplementationThe allocation-free matrix-balancing helper is a local implementation because the stdlib LAPACK wrapper used previously is not public and the hot path's zero-allocation contract must be preserved. The new tests compare it with
GenericSchur.balance!across real/complex Float32/Float64 inputs and check zero allocations.This is separate from #266, which promotes and documents
alloc_mem.Local verification
julia +release --project=. -e 'using Pkg; Pkg.test()': passed (770 tests; 1 pre-existing broken AllocCheck assertion)julia +1.10 --project=. -e 'using Pkg; Pkg.test()': passed (770 tests; same pre-existing broken assertion)GPU tests were not run locally because this machine has no available NVIDIA device.