Assert the StaticArrays extension actually loaded in QA - #264
Merged
ChrisRackauckas merged 1 commit intoAug 1, 2026
Merged
Conversation
ExplicitImports silently skips an extension whose module does not exist: `Base.get_extension` returns `nothing` and the checks report a clean pass. If the extension's precompilation later breaks, QA would go green while extension coverage silently dropped back to zero. Assert the module exists instead of trusting a green run_qa. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #263, which was merged before this guard was pushed.
Why
The extension scan that #263 turned on can be silently lost again.
ExplicitImports skips an extension whose module does not exist:
That skip is silent — every check then reports a clean pass. So if a future
change breaks
ExponentialUtilitiesStaticArraysExt's precompilation, or theusing StaticArraysline intest/qa/qa.jlgets dropped, QA goes green whileextension coverage quietly falls back to zero, which is exactly the state #263
just fixed.
What changed
Assert the extension module exists rather than trusting a green
run_qa:Verified locally that this actually discriminates rather than being vacuously
true: in a session with only
using ExponentialUtilities,Base.get_extensionreturns
nothing; afterusing StaticArraysit returns the module.Local verification
GROUP=QA julia --project=. -e 'using Pkg; Pkg.test()'on this branch:That is 22 passing versus 21 on master, the difference being the new guard. The
2 broken are the pre-existing
broken = truemarkers in the AllocCheck testset,untouched here. No package source is changed by this PR, only
test/qa/qa.jl.Please ignore this PR until it has been reviewed by @ChrisRackauckas.