Avoid cache-hit workspace allocations on Julia 1.10 - #261
Merged
ChrisRackauckas merged 2 commits intoJul 29, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 29, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores the large
exponential!workspace in a private concrete_ExponentialWorkspace{W}cell, rather than returning it by value from the cache. This removes the 64-byte Julia 1.10 allocation on warmedget_expcache!hits while using only ExponentialUtilities-owned APIs.The old return-by-value path regressed at commit
3d1e43f; releasede044eebfails the Core allocation assertion on Julia LTS hosted platforms and in the downgrade job. The initial draft used non-publicBase.RefValue; this update replaces it with the local cell so ExplicitImports passes.Validation:
ExpvCachecontrol: workspace reuse confirmed.GROUP=Core Pkg.test(; coverage=true): 738 passed, 1 expected broken, 0 failures/errors.GROUP=QA Pkg.test(; coverage=true): 19 passed, 2 expected broken, 0 failures/errors; ExplicitImports passes.git diff --checkpass.Draft — please ignore until reviewed by @ChrisRackauckas.