Skip to content

Fix uncertainty forecast trajectory indexing #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Sep 12, 2026
Merged

Fix uncertainty forecast trajectory indexing #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/basics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ function get_uncertainty_forecast(prob, sym, t, uncertainp, samples)
prob_func(prob, ctx) = sample_prob(prob)
eprob = EnsembleProblem(prob, prob_func = prob_func)
esol = solve(eprob, nothing, EnsembleSerial(), saveat = t, trajectories = samples)
return Array.(reduce.(hcat, [esol[i][sym] for i in 1:samples]))
return Array.(reduce.(hcat, [esol.u[i][sym] for i in 1:samples]))
end

"""
Expand Down
11 changes: 11 additions & 0 deletions test/basics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ quantiles = get_uncertainty_forecast_quantiles(
@test length(quantiles) == 2
@test all(size(q) == (length(t_measure), 1) for q in quantiles)

@testset "Uncertainty forecast trajectories" begin
for (symbols, initial_values) in ((x, [1.0]), ([x], [1.0]), ([x, y], [1.0, 0.0]))
forecasts = get_uncertainty_forecast(
prob, symbols, t_measure, [σ => Uniform(27.0, 29.0)], 4
)
@test length(forecasts) == 4
@test all(size(forecast) == (length(initial_values), length(t_measure)) for forecast in forecasts)
@test all(forecast[:, 1] == initial_values for forecast in forecasts)
end
end

xmin, xminval = get_min_t(prob, x)
@test sol(xmin; idxs = x) == xminval
@test sol(xmin; idxs = x) <= minimum(sol[x])
Expand Down
Loading