Repository navigation
Seed a new rng instead of copying TaskLocalRNG - #340
Open
jitendravjh wants to merge 1 commit into
Open
jitendravjh wants to merge 1 commit into
jitendravjh wants to merge 1 commit into
Conversation
copy on a TaskLocalRNG snapshots the current task local state, so noise processes built back to back started from the same state and produced identical noise.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copyon aTaskLocalRNGsnapshots the current task local state, so two processes built back to back with norandin between started from the same state and produced identical noise.Now the seed is drawn from the task local rng instead, so each process gets its own stream. An explicitly passed rng is untouched, and a fixed
Random.seed!is still reproducible.Closes #258