This repository was archived by the owner on May 12, 2026. It is now read-only.
Improve explicit imports hygiene#170
Merged
ChrisRackauckas merged 1 commit intoJan 3, 2026
Merged
Conversation
This PR adds explicit imports to improve code clarity and maintainability: 1. Added explicit imports for all used functions from dependencies - CommonSolve: init, solve, step! - SciMLBase: DAEProblem, DESolution, EnsembleProblem, etc. - RecipesBase: @recipe, @Series - RecursiveArrayTools: recursive_mean, vecvecapply - DiffEqNoiseProcess: NoiseGrid, NoiseWrapper - StructArrays: StructArray - NLsolve: nlsolve - LinearAlgebra: /, \ - RootedTrees: RootedTreeIterator, RungeKuttaMethod, residual_order_condition - Statistics: mean, std - Base: convert, transpose 2. Removed stale import of AbstractDDEProblem (not used) 3. Added CommonSolve to dependencies (was only a transitive dependency before) 4. Added ExplicitImports.jl tests to CI to prevent regression All tests pass, including the new ExplicitImports hygiene tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code clarity and maintainability by adding explicit imports for all used functions from dependencies and removing stale imports.
Changes
Added explicit imports for all used functions from dependencies:
init,solve,step!DAEProblem,DESolution,EnsembleProblem,EnsembleSolution,EnsembleThreads,NonlinearProblem,ODEProblem,ReturnCode,SDDEProblem,SDEProblem,remake@recipe,@seriesrecursive_mean,vecvecapplyNoiseGrid,NoiseWrapperStructArraynlsolve/,\RootedTreeIterator,RungeKuttaMethod,residual_order_conditionmean,stdconvert,transposeRemoved stale import of
AbstractDDEProblem(not used)Added CommonSolve to dependencies - was only a transitive dependency before, now explicit
Added ExplicitImports.jl tests to CI to prevent regression and maintain import hygiene
Testing
ExplicitImports.jl:Benefits
cc @ChrisRackauckas
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com