This repository was archived by the owner on May 12, 2026. It is now read-only.
Fix bugs found by JET static analysis#166
Merged
ChrisRackauckas merged 1 commit intoDec 30, 2025
Merged
Conversation
- Fix typo: ShootOut -> Shootout in deprecated ode_shootout function
- Fix undefined variable: errsol should be sol when appxsol is nothing in BVP WorkPrecision
- Fix unqualified reference: calculate_ensemble_errors -> DiffEqBase.calculate_ensemble_errors
These issues were discovered by running JET.report_package("DiffEqDevTools").
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 3 bugs discovered by running JET.jl static analysis (
JET.report_package("DiffEqDevTools")):ShootOut→Shootoutinode_shootoutfunction (src/benchmark.jl:37)appxsol === nothingin the BVPWorkPrecisionfunction, the code incorrectly referencederrsol.errorswhich doesn't exist - changed tosol.errorsto match the ODE version (src/benchmark.jl:351-352)calculate_ensemble_errors→DiffEqBase.calculate_ensemble_errors(src/test_solution.jl:125)JET Analysis Results
Before this PR: 38 possible errors
After this PR: 35 possible errors (remaining are in upstream packages or false positives)
Test plan
Pkg.test()completed successfully)cc @ChrisRackauckas
🤖 Generated with Claude Code