Update documentation of save_start and save_end#977
Conversation
| as the final timepoint. This setting is overridden by other saving settings when set to | ||
| `false`. Defaults to |
There was a problem hiding this comment.
That shouldn't be the case. save_start and save_end should be concrete and overriding in that sense. The solution here isn't to document a current bug.
There was a problem hiding this comment.
That's on me then; I interpreted SciML/OrdinaryDiffEq.jl#1842 (comment) to mean that the current behaviour should be documented. I'll mark both PRs for this as WIP.
Let's discuss this in more detail in that issue to keep everything centralised.
|
Hi @ArneBouillon, This PR contains a valuable documentation improvement for The PR currently shows a large diff that would revert many important changes including:
To update this PR:
If you're unable to do this, I'd be happy to apply the documentation changes to a fresh PR. The documentation clarification itself is helpful and addresses the issue mentioned in OrdinaryDiffEq.jl#1842. 🤖 Generated with Claude Code |
Clarify the complicated current behaviour of `save_start` and `save_end` in the documentation, addressing the issue mentioned in OrdinaryDiffEq.jl#1842. This is a rebased version of PR SciML#977 by @ArneBouillon, which was significantly behind master. Co-Authored-By: ArneBouillon <45404227+ArneBouillon@users.noreply.github.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 participants
Fixes SciML/OrdinaryDiffEq.jl#1842
A proposal to clarify the complicated current behaviour of
save_startandsave_endin the documentation.