Allowlist public implicits identifier for typos 1.50 - #682
Merged
ChrisRackauckas merged 1 commit intoSep 9, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
crate-ci/typos 1.50.0 added `implicits -> implicit` to the dictionary. DataDrivenDiffEq uses `implicits` as a public Basis keyword and as a local name matching `implicit_variables`; renaming would be noisy. Spell Check CI consumes SciML/.github's reusable workflow @v1, which now pins crate-ci/typos@v1.50.1, so every PR fails on master. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Grok <noreply@x.ai> Agent-Harness: Grok Build 1.0.24 Agent-Model: grok-4.6 Agent-Session: 01a08654-45f1-7a53-849c-56a7f1531d56 (local Grok Build session; no public conversation URL)
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/DataDrivenDiffEq.jl
that referenced
this pull request
Sep 9, 2026
Stacked on SciML#682. The allowlist is a separate mechanical PR; this merge only unblocks Documentation CI on the linkcheck branch. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Grok <noreply@x.ai> Agent-Harness: Grok Build 1.0.24 Agent-Model: grok-4.6 Agent-Session: 01a08654-45f1-7a53-849c-56a7f1531d56 (local Grok Build session; no public conversation URL)
ChrisRackauckas
marked this pull request as ready for review
September 9, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed and why
crate-ci/typos1.50.0 addedimplicits -> implicitto the dictionary (crate-ci/typos#1611, v1.50.0). DataDrivenDiffEq usesimplicitsas a publicBasiskeyword and as a local name matchingimplicit_variables; renaming would be noisy and breaking. SciML/.github's reusable Spell Check workflow@v1now pinscrate-ci/typos@v1.50.1(SciML/.github#129), so Spell Check fails on current master and on unrelated PRs such as #681.This PR only adds
implicits = "implicits"to.typos.toml[default.extend-words].Bisect
The identifier is not a recent DataDrivenDiffEq regression.
implicits:a0145ce982a3abec100ef32f42629676a7334939(Get ready for implicit optimizers, 2021-03-29). Found bygit bisectover current master: bad iff a.jlfile containsimplicitsand.typos.tomldoes not allowlist it.candidate.jloccurrence (implicits = implicit_variables(basis)) landed indc6c7b3d4c9291090f9be07f4a92e9cd374a7a41(Lux (#427), 2022-12-18).8526cd292905ae49a81eba4b50773f8b06f42c8a, 2025-07-29) withcrate-ci/typos@v1.18.0, which did not flagimplicits.crate-ci/typos1.49.0 → 1.50.1). DataDrivenDiffEq callsSciML/.github/.github/workflows/spellcheck.yml@v1. Confirmed locally: typos 1.47.0 / 1.48.0 / 1.49.0 exit 0 on master; 1.50.0 and 1.50.1 exit 2 with 57implicitshits.#680 already mixed this same allowlist line into the x86-lane drop. Once this lands, that line can be dropped from #680 so that PR stays single-purpose.
Verification
Master
9d31f922withtypos-cli 1.50.1(CI pin):This branch with the same binary:
Local default
typos-cli 1.47.0still passes (it never flaggedimplicits).What I did not verify
.typos.toml.crate-ci/typosor SciML/.github; those stay on the floating@v1reusable workflow.Reviewer notes
implicitsis public API (Basis(..., implicits = ...)), not a misspelling ofimplicit. Allowlisting is the intended SciML fix; a rename would be breaking.🤖 Generated with Grok Build 1.0.24 (model: grok-4.6)
Agent-Session: 01a08654-45f1-7a53-849c-56a7f1531d56 (local Grok Build session; no public conversation URL)
Links