Use SciMLTesting v1.2 (folder-based run_tests)#99
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Merged
Conversation
Replace the hand-written GROUP dispatcher in test/runtests.jl with the SciMLTesting v1.2 folder-discovery model (`using SciMLTesting; run_tests()`). - Core = top-level test/*.jl. Extract the inline "Testing maxorder" testset into test/maxorder_tests.jl; the other Core files stay at the top level. - Move alloc_tests.jl and explicit_imports.jl into test/shared/ (they are QA-only includes, not their own Core files) and update qa.jl's includes. - QA = test/qa/qa.jl, run in the test/qa sub-env. - Add SciMLTesting + SafeTestsets to the root test deps and test/qa/Project.toml; drop Pkg from the root test deps (the harness owns Pkg ops, no test/*.jl uses it). - test_groups.toml unchanged. Per-GROUP test set is unchanged. Verified statically (TOML + parse) and end-to-end with GROUP=QA on Julia 1.11 (20/20 pass). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
b09e82e to
2a5b150
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2 folder-discovery model:
test/runtests.jlbecomesusing SciMLTesting; run_tests(), and the per-GROUP test set is derived from the folder layout +test/test_groups.toml.Layout
test/*.jl. The inline "Testing maxorder" testset was extracted intotest/maxorder_tests.jl; the other Core files (common.jl,convergence.jl,initialization_tests.jl,inplace_tests.jl,interface.jl,mtk_initialization_tests.jl) stay at the top level.alloc_tests.jlandexplicit_imports.jlmoved intotest/shared/(they are QA-only includes, not their own Core files) andqa.jl's include paths updated. This keeps Core's top-level glob from running them.test/qa/qa.jl, run in thetest/qasub-env.Deps
SciMLTesting+SafeTestsetsto the root test deps ([extras]/[targets].test/[compat]) and totest/qa/Project.toml.Pkgfrom the root test deps (the harness owns Pkg ops; notest/*.jlreferences it).test/test_groups.tomlunchanged.Verification
TOML.parsefileon every Project.toml + test_groups.toml;Meta.parseallon runtests.jl + all moved/new files.GROUP=QA→QA/qa.jl 20/20 pass. Core path is the standard folder-discovery flow (per-PR CI exercises its ModelingToolkit/NonlinearSolve deps).The exact set of tests run under each GROUP value is unchanged. Supersedes the older v1.0.0 run_tests form on this branch.
Ignore until reviewed by @ChrisRackauckas.