Canonical CI: grouped-tests.yml + root test/test_groups.toml#98
Merged
ChrisRackauckas merged 4 commits intoJun 10, 2026
Merged
Conversation
Convert the root Tests.yml from a hand-maintained version x os matrix calling tests.yml@v1 into a thin caller of the canonical grouped-tests.yml@v1, with the matrix declared once in test/test_groups.toml. - Tests.yml: replace the matrix test job with the thin grouped-tests.yml@v1 caller (secrets: inherit); on:/concurrency: preserved verbatim. No `with:` needed -- all defaults match the prior setup (GROUP env name, check-bounds=yes, coverage on, src,ext). - test/test_groups.toml: [Core] on [lts,1,pre] x [ubuntu-latest, windows-latest] (preserves the old functional os coverage); [QA] on [lts,1]. - Isolate the QA checks (ExplicitImports, type-stability, AllocCheck allocation tests) into a gated GROUP=="QA" path with its own test/qa/Project.toml ([sources] DASSL path=../.., julia="1.10") and test/qa/qa.jl; runtests.jl activates/develops/instantiates it for QA. - Project.toml: drop AllocCheck/ExplicitImports from the root test target (now QA-isolated); add missing [compat] entries for the remaining [extras] (DAEProblemLibrary, ModelingToolkit, Test). julia compat already at the 1.10 LTS floor. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The grouped runtests.jl uses Pkg for the QA group's Pkg.activate, but the Core group runs with project='.' (the root test env). Pkg was not a declared test dependency, so the Core job died with ArgumentError: Package Pkg not found in current path. Declare Pkg in [extras] and add it to [targets].test. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The grouped-tests conversion removed functional test dependencies from the root test environment while isolating QA, breaking the Core group. Re-add the deps that the pre-conversion base test target listed (using their base UUIDs) so Core resolves and @testset/@safetestset/domain macros are defined. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…Error The converted runtests.jl placed `using` statements inside a top-level `if GROUP ...` block that also used a macro (e.g. @testset) inline. Julia macro-expands the entire if block as one unit before the in-block `using` executes, so the macro was undefined (UndefVarError: @testset not defined in Main). Move the functional usings to top level (the QA-subenv usings that follow Pkg.activate stay in the QA block). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root Tests.yml from a hand-maintained
version × osmatrix (callingtests.yml@v1) into a thin caller of the canonicalgrouped-tests.yml@v1, with the test matrix declared once intest/test_groups.toml.Changes
.github/workflows/Tests.yml— the matrix test job is replaced by the canonical thin caller:name:,on:, andconcurrency:are preserved verbatim. Nowith:block is needed — every input matches the canonical default and the prior behavior (group envGROUP,check-bounds: yes, coverage on,coverage-directories: src,ext, no apt packages). Other workflows (Downgrade/FormatCheck/RunicSuggestions/SpellCheck/TagBot/DependabotAutoMerge) are untouched.test/test_groups.toml(new) — the matrix:GROUP=="all"/"QA", withAllocCheck/ExplicitImportsin the root test target. They are now refactored into a gatedGROUP=="QA"path with an isolated environment:test/qa/Project.toml—[deps]= AllocCheck + ExplicitImports + Test + LinearAlgebra + DASSL via[sources] path = "../..";[compat] julia = "1.10".test/qa/qa.jl— the moved QA testset (ExplicitImports, type-stability, alloc tests).test/runtests.jl—Core/Allrun the functional suite;QAdoesPkg.activate(test/qa)+Pkg.develop(path=repo root)+Pkg.instantiate()then includesqa.jl. Group dispatch updated to the canonical capitalized names (All/Core/QA).Project.toml— benign metadata fixes: droppedAllocCheck/ExplicitImportsfrom the root[extras]/[targets](now QA-isolated); added missing[compat]for the remaining extras (DAEProblemLibrary = "0.1",ModelingToolkit = "10, 11",Test = "1").juliacompat already at the 1.10 LTS floor.Matrix match
Verified statically with
scripts/compute_affected_sublibraries.jl --root-matrix(no tests/Aqua run locally — structural conversion only). Emitted set:{lts, 1, pre} × {ubuntu-latest, windows-latest}= 6 cells → exactly reproduces the OLD functionalversion × oscoverage.{lts, 1} × {ubuntu-latest}= 2 cells → the QA checks (previously riding along on all 6 cells via the defaultGROUP=all) now run isolated on the canonical QA subset.TOML + YAML parse and
runtests.jl/qa.jlJulia-parse were verified statically.Note
The QA group is newly wired as a separate CI job; its Aqua/JET (here: ExplicitImports + type-stability + AllocCheck) run in CI. Any failures will be triaged in a follow-up — no checks were skipped or silenced.
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code