Skip to content

Run Runic formatter on the repository#94

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:runic-format
Jun 5, 2026
Merged

Run Runic formatter on the repository#94
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:runic-format

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Please ignore until reviewed by @ChrisRackauckas. Draft.

Runs the Runic.jl v1 formatter over the repository so the format-check CI (the centralized SciML/.github/.github/workflows/runic.yml@v1 reusable workflow, fredrikekre/runic-action@v1) passes.

Change

The only change is in test/runtests.jl: a let ... end one-liner (introduced in #93) expanded to multi-line form. This is what currently makes format-check red on master.

-const GROUP = let g = get(ENV, "GROUP", "all"); isempty(g) ? "all" : g end
+const GROUP = let g = get(ENV, "GROUP", "all")
+    isempty(g) ? "all" : g
+end

Formatting-only and semantically identical. The other 13 tracked .jl files were already Runic-clean.

Verification (clean-room, independent fresh clones)

  • CI parity: fresh depot + fresh Runic v1.7.0 (the version runic-action@v1 resolves), runic --check over git ls-files '*.jl' (14 files) → exit 0, no diff. CI format-check will pass.
  • Semantic identity: only test/runtests.jl differs from master; the const GROUP value is identical for GROUP unset/""/"all"/"core"/"QA"; and Meta.parseall with LineNumberNodes stripped compares AST-equal between the two versions.
  • Tests: full suite on the formatted tree (Julia 1.10) → 184 pass / 0 fail, Pkg.test exit 0 (ModelingToolkit DAE Initialization 46/46, Testing common interface 4/4, QA 20/20).

🤖 Generated with Claude Code

Apply Runic.jl v1 formatting so the FormatCheck CI (the centralized
SciML/.github runic.yml@v1 reusable workflow) passes. The only change is
expanding a `let ... end` one-liner in test/runtests.jl into multi-line form;
it is formatting-only and semantically identical. `runic --check` over
`git ls-files '*.jl'` is clean after this commit.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 5, 2026 08:27
@ChrisRackauckas ChrisRackauckas merged commit e2288ba into SciML:master Jun 5, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants