Cache Shooting ODE integrators by eltype - #570
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
Member
Author
Contributor
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this draft until reviewed by @ChrisRackauckas.
Fixes BoundaryValueDiffEqShooting multiple-shooting caches when residual AD
changes the state/time element type. The existing cache held Float64 time
storage and attempted to convert ForwardDiff dual times to Float64.
The cache is now keyed by state element type and number of shooting intervals.
For a nonmatching element type it is remade with a matching
tspan; resulttime containers are derived from the cache rather than the primal span. This
keeps the primal path unchanged and avoids losing AD information.
Clean-main reproduction and validation on Julia 1.10 with the exact all-deps
resolver:
masterf41609edfails Basic Shooting atFloat64(::ForwardDiff.Dual)(54 pass, 1 error);56/56, Orbital 40/40; and
Runic --check .andgit diff --checkpass.The regression bisects to
fe630c86.