Restore sublibrary project metadata before downgrade QA - #131
Merged
ChrisRackauckas merged 1 commit intoSep 7, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: gpt-5.6-sol Agent-Session: 01a059b1-5fa2-76a2-937a-33502aa35de5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The
julia-downgrade-compataction now promotes old-style[targets].testextras into[deps]soPkg.test(; allow_reresolve=false)can retain their locked versions. For QA groups, Aqua consequently inspects the action-mutated project rather than the package's source metadata: it reports every promoted test extra as stale, and ModelingToolkitBase's promotedModelingToolkitStandardLibrary/DiffEqNoiseProcessdependencies create a precompile cycle that fails the persistent-tasks check.Save each sublibrary's original
Project.tomlbefore downgrade resolution and restore it after the downgraded build but before QA. This matches the existing root downgrade workflow: the build remains pinned to the downgraded manifest, while metadata-oriented QA checks inspect the source project rather than a transient action mutation.Please ignore this draft until it has been reviewed by @ChrisRackauckas.
Regression evidence
The new workflow-order regression test failed on the unfixed workflow:
After the workflow change, the same test passes:
I also reproduced the current ModelingToolkitBase failure locally from clean detached ModelingToolkit master
e91f13e48fc4f2fdda67e66ad7b2d9c67234ac2busing Julia 1.10.12 and the exact downgrade action revision used by CI (30b83cf94e89744fcbd7ea5496be4967d6fbe540). Before restoringlib/ModelingToolkitBase/Project.toml, QA reported17 passed, 2 failed(Stale dependenciesandPersistent tasks). Restoring the sourceProject.tomlbefore the same lockedPkg.testinvocation produced:The same failure is present on current ModelingToolkit master in https://github.com/SciML/ModelingToolkit.jl/actions/runs/33444272942/job/99729331320. The behavior was introduced by julia-actions/julia-downgrade-compat@30b83cf.
Verification
Not verified before opening: a live downstream invocation of this reusable-workflow branch. The local ModelingToolkitBase run above exercises the same save/downgrade/build/restore/test behavior.
🤖 Generated with Codex CLI 0.151.0 (model: gpt-5.6-sol; session: 01a059b1-5fa2-76a2-937a-33502aa35de5).