Repair restored sublibrary downgrade metadata - #130
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Restore the original QA project after downgrade and rebuild only its local Manifest entry. This preserves downgraded dependency versions while removing promoted test extras from the package's own dependency metadata. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: unknown Agent-Session: local session ID 01a04fa1-cfe0-7260-b416-72fe8a15d17d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed
QA downgrade jobs now save and restore the package's original
Project.toml, then repair only that local package's entry in the downgrade-generatedManifest.toml. This retains the locked downgraded dependency/test-extra versions while removing test-only dependencies thatjulia-downgrade-compattemporarily promoted into the package's own dependency metadata.The helper deliberately does not call
Pkg.resolve(): resolving the restored project removed 151 locked test-environment packages in the reproduced ModelingToolkitBase graph. It preserves every non-main Manifest entry and removes the now-staleproject_hashrather than using Pkg internals to synthesize one.Failing before
On clean ModelingToolkit
origin/mastercommit6b06080fe1c19a0fc99f5e1e32ed3309b847e201, the exact downgrade workflow under Julia 1.10.12 produced:The stale-dependency set contained the promoted test extras. The persistent-task subprocess reported the synthetic
ModelingToolkitBase -> ModelingToolkitStandardLibrary -> ModelingToolkitBasecycle and never created Aqua's completion file. The ExplicitImportsUnPackerror also reproduces in an untouched current-resolver control and is tracked separately on the ModelingToolkit PR linked below.Passing after
Applying the restore/repair to the real downgraded PR graph produced these invariants:
In a never-used writable depot, with
JULIA_NUM_PRECOMPILE_TASKS=1andJULIA_PKG_PRECOMPILE_AUTO=0, the original two downgrade-specific assertions then completed warning-free:No stale dependency, persistent task, dependency cycle, stale pidfile, Moshi overwrite, or duplicate-include output occurred in that fresh-depot targeted run.
Repository verification
Validation limitation
I did not claim a clean full ModelingToolkitBase QA pass. An untouched fresh-depot control at the PR commit itself emits the same 31 package-wide JET method-overwrite warnings as the historical GitHub job; that independent harness defect is filed below. Today's resolver also exposes the independent
UnPackExplicitImports drift. Neither condition is introduced by this Manifest repair, but both prevent using the full current QA output as uncontaminated passing evidence.No documentation or public API changed, so no docs build was run.
Links
🤖 Generated with Codex CLI 0.151.0 (model: unknown).
Session: local session ID 01a04fa1-cfe0-7260-b416-72fe8a15d17d