Fix BDSC resolution normalization for resolver - #42
Open
ADiglet wants to merge 1 commit into
Open
Conversation
Collaborator
|
This should already be handled in the code here Lines 328 to 335 in 45a4f51 |
Collaborator
|
Looking at this again, the logic for switching (or not switching) the separator based on whether ag (the adgene separator pattern match) is present is bad. If the BDSC match is happening in that code and not in the third round then it needs a more extensive rework to handle the special cases where a double |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes BDSC identifier normalization in SciBot resolver calls.
Previously, BDSC identifiers matched in the form BDSC:XXXX could be passed to the resolver as RRID:BDSC:XXXX, which led to unresolved results.
This change normalizes BDSC matches to RRID:BDSC_XXXX for resolver submission.