[Schnee111]

Fixes #74

What this fixes

Pressing Esc in the rice switcher menu switched and logged out instead of cancelling. gui_menu runs in ACTION="$(gui_menu)", so its exit 0 on cancel left only the subshell and ACTION came back empty. Then switch_to "" went on:

1. rices/ passed the directory check;
2. install.sh --rice "" relinked the current rice;
3. an empty .current_rice was written;
4. the session logged out.

Approach

• Right after gui_menu, an empty ACTION exits 0. That covers Esc, a closed menu and a row that matches nothing.
• switch_to accepts only names matching ^[A-Za-z0-9][A-Za-z0-9._-]*$. An empty or path-like name (../end4, ., -x) now fails with Invalid rice name instead of resolving to rices/ or outside it. status and list are handled before this check, so they are unchanged.
• New tests/rice-switch.sh runs every case with --dry-run and a stub rofi:
  • Esc (exit 1) and an empty choice (exit 0, no output) both exit 0 and print nothing;
  • a chosen row still reaches the switch;
  • four invalid names are rejected.

Verification

• bash tests/run.sh: all test files pass. shellcheck reports no new findings; the SC2015 info at line 146 is from before this change.
• Negative control: with bin/rice-switch from main, the test fails with esc: expected no output, the switch ran: rice-switch: dry run for '' ....

Risk

Low. Only the cancel path and invalid names behave differently. Every name under rices/ matches the pattern.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[Schnee111]

Autonomous Code Review

Verdict: Approved
Target Commit: 217a600

Summary

Effectively fixes the session logout and rice state corruption when cancelling the menu by exiting early on empty selections and validating rice names against path traversal.

---

Shorekeeper Sentinel · Autonomous Quality Gate