Repository navigation
fix(end4): store the adaptive window opacity in the shell's options - #73
Merged
Merged
Conversation
The shell's Hyprland settings page rewrites shellOverrides/main.lua from config.json when it opens, which put back the last saved opacity over the value apply_adaptive_glass.sh had just set from the wallpaper. Write the same values to hyprland.decoration in config.json (skipped in solid mode, when unchanged, or when the file does not parse), through a symlink without replacing it. Fixes #72
Schnee111
commented
Oct 25, 2026
Schnee111
left a comment
Owner
Author
There was a problem hiding this comment.
Autonomous Code Review
Verdict: Approved
Target Commit: 4802799
Summary
Safely propagates adaptive window opacity values into the shell's config.json with symlink preservation, no-op verification, and comprehensive test coverage.
Shorekeeper Sentinel · Autonomous Quality Gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
What this fixes
apply_adaptive_glass.shsets window opacity from the wallpaper and writes it toshellOverrides/main.lua. When the shell's Hyprland settings page opens, it rewrites that file from its stored options in~/.config/illogical-impulse/config.json, so the opacity went back to the last saved value (here0.86/0.76instead of0.88/0.78) until the next wallpaper change.Approach
The script now also writes
hyprland.decoration.activeOpacity/inactiveOpacityinto the shell'sconfig.json, so the settings page writes back the wallpaper's value. Opacity keeps following the wallpaper, which is the intended behaviour.main.luawrite, and whenjqis missing.jq, then a temp file andmvon the resolved path (readlink -f). Aconfig.jsonthat is still a symlink into dotfiles stays a symlink, and the rename is atomic, as with the shell's own saves..tmpfile is left behind.tests/adaptive-glass.shgets new checks:config.json;Verification
bash tests/run.sh: all test files pass.shellcheckis clean on both files.mainand the new checks kept, the test fails withlum 50: expected [0.88,0.78], got [0.86,0.76].config.jsonholds[0.88, 0.78]and is still there after the shell's reload;main.luaholds0.88/0.78;hyprctl getoption decoration:active_opacityreads0.88;configerrorsis empty.Risk
Low. An opacity set by hand in the settings page lasts only until the next wallpaper change, which is the intended behaviour. Solid mode still pins it.