Repository navigation
fix(end4): state focusOnActivate in the shell config too - #71
Merged
Merged
Conversation
The shell's Hyprland settings page writes misc:focus_on_activate from config.json into shellOverrides/main.lua, which loads after custom/general.lua. config.json had no hyprland.misc, so the shell wrote its default false over the rice's true. Set the same value there, and add a test that the two agree. Fixes #70
Schnee111
commented
Oct 25, 2026
Schnee111
left a comment
Schnee111
left a comment
Owner
Author
There was a problem hiding this comment.
Autonomous Code Review
Verdict: Approved
Target Commit: 08bcdaa
Summary
Correctly synchronizes hyprland.misc.focusOnActivate in the shell configuration to match Hyprland's custom/general.lua, preventing shell override resets. The accompanying regression test is sound and properly handles default fallbacks.
Shorekeeper Sentinel · Autonomous Quality Gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
What this fixes
custom/general.luaenablesmisc:focus_on_activate(2447308), but the live value wasfalse. The shell's Hyprland settings page writes all of its stored options intoshellOverrides/main.luawhen it opens, and that file loads aftercustom/general.lua. Ourconfig.jsonhad nohyprland.misc, so the shell wrote its defaultfalse(the option was added upstream in 95ce5b6).Approach
rices/end4/illogical-impulse/config.jsongetshyprland.misc.focusOnActivate: true. The key is inserted in Qt's sorted order with the file's 4-space format, so the diff is three lines.tests/shell-overrides-agree.sh: for each rice that has both files,focus_on_activateincustom/general.luamust equalhyprland.misc.focusOnActivateinconfig.json. A missing key counts asfalse, the shell's default. CI already hasjq.The shell side is not changed, because its default matches Hyprland's. The rice simply has to state its choice in the shell's config as well.
Verification
bash tests/run.sh: all test files pass.shellcheckis clean.config.jsonfrommain, the new test fails withcustom/general.lua focus_on_activate = true, config.json hyprland.misc.focusOnActivate = false.~/.config/illogical-impulse/config.json, and the shell reloaded it (watchChanges);shellOverrides/main.luawas rewritten with the shell's ownhyprconfigurator.py --set misc:focus_on_activate 1;hyprctl reload config-only,hyprctl getoption misc:focus_on_activatereadstrue, andconfigerrorsis empty.Risk
Low. The setting now has one value in both places. Turning it off from the settings page still works as before; it then overrides
custom/general.luaagain, which is that page's purpose.