Fix breakage on main catbox endpoints#35
Merged
Savolae merged 4 commits intoSavolae:mainfrom Jan 12, 2024
RivenSkaye:main
Merged
Fix breakage on main catbox endpoints#35Savolae merged 4 commits intoSavolae:mainfrom RivenSkaye:main
Savolae merged 4 commits intoSavolae:mainfrom
RivenSkaye:main
Conversation
Contributor
Author
|
I just noticed that I'd forgotten to bump the version in Cargo.toml. Fixed that so the release workflow won't break on a new tag |
Contributor
Author
|
Oh god, I just noticed I forgot to update the lockfile itself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34 by changing
Client::new()toClient::builder()and adding a User Agent string on all calls to Catbox. A comment on the issue I opened mentioned setting a UAString works to make catbox functional again. It also bumps the dependencies to make it build successfully on both nightly and stable toolchains again, as dtolnay/proc-macro2#391 wasn't included in the last pinned version of the transitive dependency that was included through at least Clap.The UAString used is built up using env vars set by Cargo at build time expanded using the
std::env!macro, so no new dependencies are added. I've also taken the liberty of adding the UAString to thelittersubcommands to prevent future breakage there.