Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 236e9f4f9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
318a8f9 to
e3463d4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c9e1ea360
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
This PR adds Spring Boot 4 compatibility across Dubbo Spring Boot modules while keeping the existing default / Spring Boot 2 and Spring Boot 3 paths isolated.
Spring Boot 4 profile and dependency management
spring-boot-4profile with Spring Boot 4, Spring Framework 7, Tomcat 11, JUnit 6, SLF4J / Logback, Jackson, and the new Spring Boot 4 split artifacts.dubbo-spring-boot-4-autoconfigureanddubbo-spring-boot-4-starterto the reactor, artifact list, BOM, and dependency-all coverage.spring-boot-3andspring-boot-4profile wiring where Spring Boot version selection matters.New Spring Boot 4 autoconfigure and starter modules
dubbo-spring-boot-4-autoconfigure.spring.factoriesandAutoConfiguration.imports.dubbo-spring-boot-4-starterand wire tracing Zipkin starters to include Boot 4 auto-configuration under thespring-boot-4profile.Spring Boot version conditions
SpringBoot4ConditionandSpringBootBefore4Condition.SpringBoot3Conditionso Boot 4 no longer matches the Boot 3 condition.Spring Boot 4 API compatibility
DubboHealthIndicatorusing the new Spring Boot health contributor package.Demo and compatibility modules
dubbo-config-spring.Supporting compatibility fixes
Tests and guards
FileTestguards for Spring Boot 3 / 4 profile dependency isolation, Boot 4 artifacts, BOM coverage, source-set wiring, starter wiring, and auto-configuration resource registration.Why
Spring Boot 4 changes several compatibility boundaries:
This PR makes the Spring Boot version boundaries explicit and adds regression guards so future dependency changes do not silently break default, Spring Boot 3, or Spring Boot 4 builds.
Verification
Validated with full reactor checks for the supported profiles:
Default profile / Spring Boot 2 baseline on JDK 8:
clean test verify7273tests,0failures,0errorsSpring Boot 3 profile on JDK 25:
clean test verify -Pspring-boot-3,jacoco,jdk15ge-simple,!jdk15ge-add-open,skip-spotless7400tests,0failures,0errorsSpring Boot 4 profile on JDK 25:
clean test verify -Pspring-boot-4,jacoco,jdk15ge-simple,!jdk15ge-add-open,skip-spotless7400tests,0failures,0errorsAdditional checks:
spotless:checkfor root and touched modulesgit diff --check